From 3c71b528902ab1ec9c16733ebccf18a95374a787 Mon Sep 17 00:00:00 2001 From: Honest Bot Date: Mon, 18 Jul 2022 10:25:18 +0000 Subject: [PATCH] chore: Synced file(s) with honestbank/.github --- .github/workflows/build.yaml | 5 ----- .github/workflows/semantic-pr.yaml | 18 +++++++++++++++++- .gitignore | 4 ++++ .pre-commit-config.yaml | 2 +- 4 files changed, 22 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 1b44e42..080dc59 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -50,11 +50,6 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} continue-on-error: true - trivy_scan: - name: trivy-scan - runs-on: ubuntu-latest - steps: - - run: echo "add trivy scan" # todo release: name: semantic-release runs-on: ubuntu-latest diff --git a/.github/workflows/semantic-pr.yaml b/.github/workflows/semantic-pr.yaml index cc51e5d..de6066f 100644 --- a/.github/workflows/semantic-pr.yaml +++ b/.github/workflows/semantic-pr.yaml @@ -9,9 +9,25 @@ on: jobs: main: - name: Validate PR title + name: Semantic Pull Request runs-on: ubuntu-latest steps: - uses: amannn/action-semantic-pull-request@v4 + name: Semantic Pull Request env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + + - name: feat - verify design doc link + run: | + if [[ "${{ github.event.pull_request.title }}" == "feat:"* ]]; then + echo "Pull request title starts with feat:"; + regex='design doc: \[.+?\]\(https://www.notion.so/honestbank/.+?\)' + if [[ "${{ github.event.pull_request.body }}" =~ $regex ]]; then + echo "Pull request body contains link to a design doc 🚀"; + else + echo "Pull request does not contain a design document link - please attach the relevant design doc! Refer to https://www.notion.so/honestbank/Engineering-Design-Documents-9681402a62514306876458686bfd4157"; + exit 1; + fi; + else + echo "Pull request is not a feature, skipping design doc check"; + fi diff --git a/.gitignore b/.gitignore index 8c59369..2151e46 100644 --- a/.gitignore +++ b/.gitignore @@ -34,6 +34,7 @@ # NUCLEAR OPTION - EXCLUDES ALL JETBRAINS IDE FILES **/.idea/** +.idea/** # User-specific stuff .idea/**/workspace.xml @@ -458,3 +459,6 @@ mocks # test log file coverage.txt coverage.tmp + +# Grafana tempo files (https://grafana.com/oss/tempo/) +**/tempo-data/** diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 609c415..e8f5bf2 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -11,7 +11,7 @@ repos: - id: detect-aws-credentials args: [ '--allow-missing-credentials' ] - repo: https://github.com/golangci/golangci-lint - rev: v1.39.0 + rev: v1.45.2 hooks: - id: golangci-lint - repo: https://github.com/TekWizely/pre-commit-golang