Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hive colour tunable lights broken #134626

Closed
Tehsmash opened this issue Jan 4, 2025 · 2 comments · Fixed by #134628
Closed

Hive colour tunable lights broken #134626

Tehsmash opened this issue Jan 4, 2025 · 2 comments · Fixed by #134628
Labels
integration: hive

Comments

@Tehsmash
Copy link

Tehsmash commented Jan 4, 2025

The problem

Since the switch to Kelvin patch colour tunable lights are broken because of an unbound variable here: https://github.com/home-assistant/core/blob/dev/homeassistant/components/hive/light.py#L119

@epenet I believe this was introduced in your recent change

What version of Home Assistant Core has the issue?

2025.1.0

What was the last working version of Home Assistant Core?

2024.12.5

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Hive

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Logger: homeassistant.components.light
Source: helpers/entity_platform.py:737
integration: Light (documentation, issues)
First occurred: 08:01:29 (1 occurrences)
Last logged: 08:01:29

hive: Error on device update!
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 737, in _async_add_entity
    await entity.async_device_update(warning=False)
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1318, in async_device_update
    await self.async_update()
  File "/usr/src/homeassistant/homeassistant/components/hive/light.py", line 119, in async_update
    if color_temp is None
       ^^^^^^^^^^
UnboundLocalError: cannot access local variable 'color_temp' where it is not associated with a value

Additional information

No response
@epenet epenet mentioned this issue Jan 4, 2025
Merged
19 tasks
@epenet
Copy link
Contributor

epenet commented Jan 4, 2025

Should be fixed by #134628 if you can test

@home-assistant
Copy link

home-assistant bot commented Jan 4, 2025

Hey there @Rendili, @KJonline, mind taking a look at this issue as it has been labeled with an integration (hive) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hive can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign hive Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)

hive documentation
hive source
(message by IssueLinks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
integration: hive
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix hive color tunable light home-assistant/core
3 participants
@Tehsmash @epenet @joostlek