Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendors bundle should be hashed, but not cachebusted #105

Open
ghost opened this issue May 4, 2020 · 2 comments
Open

vendors bundle should be hashed, but not cachebusted #105

ghost opened this issue May 4, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented May 4, 2020

The vendors bundle is now inside the versioned folder of the dist.

Users should not redownload it if it hasn't changed.

Could do a PR

@riccoarntz
Copy link
Contributor

Can't think of a reason why we shouldn't do this.. 👍

@ThaNarie
Copy link

ThaNarie commented May 5, 2020

Not only the vendors, but all things that are built by webpack can have a hash appended in the filename, and should not be in the version folder.

The only thing that potentially could be copied over to the version folder are the static files (that are just copied over and directly referenced in our code (without webpack in between).

Note: when doing this, we might need to have a look at our deploytool, since cleanup of older versions becomes more difficult (keeping built-manifest, and only removing files that were not part of the last X builds).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants