Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle process types names containing unsupported characters #188

Open
runesoerensen opened this issue Jan 25, 2025 · 0 comments
Open

Handle process types names containing unsupported characters #188

runesoerensen opened this issue Jan 25, 2025 · 0 comments

Comments

@runesoerensen
Copy link
Contributor

The CNB spec allows for process type identifiers containing alphanumeric characters and the characters ., _, and -.. This buildpack will currently try to add any detected project executables to the launch process list.

However, Heroku doesn't support process type names containing ., which is often used in .NET projects names, leading to errors when trying to deploy to Heroku. We could handle this scenario more gracefully in a few ways:

  • When no Procfile is present, we may want to either remove . from the detected process type name, and/or print a warning with relevant instructions on how to mitigate the issue (e.g. by setting the AssemblyName project property, renaming the project file, or opting out of automatic process type registration).
  • Skip process registration with Procfile #185 will allow users to opt out of this functionality altogether by adding a Procfile.
@runesoerensen runesoerensen changed the title Handle process types with unsupported characters Handle process types names containing unsupported characters Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant