Investigate using cargo as a library for test-kernels

[n0toose]

At the moment, we directly invoke cargo using Command::new to build the test-kernels. A cleaner approach would be using cargo as a library instead.

See: https://docs.rs/cargo/latest/cargo/

uhyve/tests/common.rs

Lines 10 to 37 in 0cbbc3a

	/// Uses Cargo to build a kernel in the `tests/test-kernels` directory.
	/// Returns a path to the build binary.
	pub fn build_hermit_bin(kernel: impl AsRef<Path>) -> PathBuf {
	let kernel = kernel.as_ref();
	println!("Building Kernel {}", kernel.display());
	let kernel_src_path = Path::new("tests/test-kernels");
	let cmd = Command::new("cargo")
	.arg("build")
	.arg("-Zbuild-std=std,panic_abort")
	.arg("--target=x86_64-unknown-hermit")
	.arg("--bin")
	.arg(kernel)
	// Remove environment variables related to the current cargo instance (toolchain version, coverage flags)
	.env_clear()
	// Retain PATH since it is used to find cargo and cc
	.env("PATH", env::var_os("PATH").unwrap())
	.current_dir(kernel_src_path)
	.status()
	.expect("failed to execute `cargo build`");
	assert!(cmd.success(), "Test binaries could not be build");
	[
	kernel_src_path,
	Path::new("target/x86_64-unknown-hermit/debug"),
	Path::new(kernel),
	]
	.iter()
	.collect()
	}

[n0toose]

Some comment on StackOverflow mentions that this is, indeed, still a Command::new under the hood. This may not necessarily have any short-term benefits for resolving #726.

[jounathaen]

I'm not convinced, that cargo as library has real benefits. Please reopen if you disagree 🙂

[mkroening]

I'd prefer using cargo as a library, actually.

The API being unstable for now is a blocker for me, though. We'd just generate unnecessary churn.

[jounathaen]

The docs of the library clearly state, that it is not advised to use the library externally:

The Cargo binary distributed through with Rust is maintained by the Cargo team for use by the wider ecosystem. For all other uses of this crate (as a binary or library) this is maintained by the Cargo team, primarily for use by Cargo and not intended for external use (except as a transitive dependency). This crate may make major changes to its APIs.

I don't really see that changing in the near to middle future. Therefore, I'm closing this issue again, but I'm not upset if you want to reopen it. 🙂