Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage of editor.PostTaxonomyType #100

Open
annezazu opened this issue Jul 27, 2021 · 4 comments
Open

Update usage of editor.PostTaxonomyType #100

annezazu opened this issue Jul 27, 2021 · 4 comments
Labels

Comments

@annezazu
Copy link

Pinged you in slack but, to be safe, wanted to alert you to this PR in Gutenberg that's planned: WordPress/gutenberg#33418 TLDR: it removes all props aside from “slug” from the filtered component and is likely to be a breaking change for the Radio Buttons for Taxonomies plugin based on checking against https://www.wpdirectory.net/. More details are on that PR!

@helgatheviking
Copy link
Owner

Hi Anne, Thanks for reporting this. I still don't really know React at all so in looking at the changes they don't make any sense to me.

I'm not sure when I'll have time to dig in to something this complex. Not sure this plugin is worth that kind of effort.

@Mamaduka
Copy link

Hi, @helgatheviking

I think your plugin won't require any changes. However, I would recommend testing it to be just sure when Gutenberg 11.3 is released.

@helgatheviking
Copy link
Owner

At a minimum, I'll need to duplicate the updated script and apply the radio button changes. Then serve two different scripts depending on the user's WP version. That's not too terrible... assuming the patches work with the updated gutenberg script.

@helgatheviking
Copy link
Owner

Hi @annezazu How would I version test for this? Or otherwise know when this might be the script being used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants