You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
According to the peerDependencies documentation, NPM 7 will auto-install peerDependencies if they aren't explicit dependencies of the application. This means that an in-browser application that depends on this library will end up downloading the ws library even though it's not needed.
In my opinion, we should mark ws as optional using peerDependenciesMeta, and document that node.js applications should make sure to include ws as one of their dependencies. We'll probably also want a runtime check that the ws library is present, and throw an Error with a helpful message if it's not.
The text was updated successfully, but these errors were encountered:
According to the
peerDependencies
documentation, NPM 7 will auto-installpeerDependencies
if they aren't explicit dependencies of the application. This means that an in-browser application that depends on this library will end up downloading thews
library even though it's not needed.In my opinion, we should mark
ws
as optional using peerDependenciesMeta, and document that node.js applications should make sure to includews
as one of their dependencies. We'll probably also want a runtime check that thews
library is present, and throw anError
with a helpful message if it's not.The text was updated successfully, but these errors were encountered: