From 445cbbad7b318c75c4b88d30dc13fdd5c128fb51 Mon Sep 17 00:00:00 2001 From: Benoit Ranque Date: Wed, 1 Jan 2025 16:12:26 -0400 Subject: [PATCH] comparison target columns have been simplified --- .../select_where_album_id_equals_self.json | 7 +--- ...quals_self_nested_object_relationship.json | 39 +++++++++---------- .../goldenfiles/select_where_in_column.json | 7 +--- 3 files changed, 22 insertions(+), 31 deletions(-) diff --git a/crates/tests/tests-common/goldenfiles/select_where_album_id_equals_self.json b/crates/tests/tests-common/goldenfiles/select_where_album_id_equals_self.json index cf3bc11b..19674eb7 100644 --- a/crates/tests/tests-common/goldenfiles/select_where_album_id_equals_self.json +++ b/crates/tests/tests-common/goldenfiles/select_where_album_id_equals_self.json @@ -27,11 +27,8 @@ "operator": "_eq", "value": { "type": "column", - "column": { - "type": "column", - "name": "AlbumId", - "path": [] - } + "name": "AlbumId", + "path": [] } }, { diff --git a/crates/tests/tests-common/goldenfiles/select_where_album_id_equals_self_nested_object_relationship.json b/crates/tests/tests-common/goldenfiles/select_where_album_id_equals_self_nested_object_relationship.json index 3f2f95cd..b87554c3 100644 --- a/crates/tests/tests-common/goldenfiles/select_where_album_id_equals_self_nested_object_relationship.json +++ b/crates/tests/tests-common/goldenfiles/select_where_album_id_equals_self_nested_object_relationship.json @@ -79,28 +79,25 @@ "operator": "_gt", "value": { "type": "column", - "column": { - "type": "column", - "name": "ArtistId", - "path": [ - { - "relationship": "TrackToAlbum", - "arguments": {}, - "predicate": { - "type": "and", - "expressions": [] - } - }, - { - "relationship": "AlbumToArtist", - "arguments": {}, - "predicate": { - "type": "and", - "expressions": [] - } + "name": "ArtistId", + "path": [ + { + "relationship": "TrackToAlbum", + "arguments": {}, + "predicate": { + "type": "and", + "expressions": [] } - ] - } + }, + { + "relationship": "AlbumToArtist", + "arguments": {}, + "predicate": { + "type": "and", + "expressions": [] + } + } + ] } } }, diff --git a/crates/tests/tests-common/goldenfiles/select_where_in_column.json b/crates/tests/tests-common/goldenfiles/select_where_in_column.json index c732ba93..870ae51e 100644 --- a/crates/tests/tests-common/goldenfiles/select_where_in_column.json +++ b/crates/tests/tests-common/goldenfiles/select_where_in_column.json @@ -19,11 +19,8 @@ "operator": "_in", "value": { "type": "column", - "column": { - "type": "column", - "name": "series", - "path": [] - } + "name": "series", + "path": [] } } },