Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade hashicorp/go-getter dependency #36326

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Upgrade hashicorp/go-getter dependency #36326

merged 2 commits into from
Jan 21, 2025

Conversation

SarahFrench
Copy link
Member

Fixes #

Target Release

1.11.x

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@SarahFrench SarahFrench changed the title Upgrade go getter Upgrade hashicorp/go-getter dependency Jan 15, 2025
@SarahFrench
Copy link
Member Author

gcs backend tests pass

@SarahFrench SarahFrench marked this pull request as ready for review January 15, 2025 12:53
@SarahFrench SarahFrench requested review from a team as code owners January 15, 2025 12:53
liamcervante
liamcervante previously approved these changes Jan 15, 2025
View reviewed changes
jar-b
jar-b previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% TF_ACC=1 go test ./...
ok      github.com/hashicorp/terraform/internal/backend/remote-state/s3 204.874s

@SarahFrench SarahFrench dismissed stale reviews from jar-b and liamcervante via 0a06e0e January 15, 2025 15:30
@SarahFrench
Copy link
Member Author

Sorry all - I needed to address merge conflicts so rebased

@SarahFrench SarahFrench merged commit a8b126a into main Jan 21, 2025
11 checks passed
@SarahFrench SarahFrench deleted the upgrade-go-getter branch January 21, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsa0x dsa0x dsa0x approved these changes

@liamcervante liamcervante liamcervante left review comments

@jar-b jar-b jar-b left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SarahFrench @jar-b @dsa0x @liamcervante