Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/oss: Adds new arguement tablestore_instance_name used to VPC scenario #36253

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

xiaozhu36
Copy link
Contributor

Terraform State OSS Backend uses Alibaba Cloud Tablestore to store state lock. There needs setting an instance name when putting lock data. Before, the instance name defaults to parsing from argument tablestore_endpoint, but it will not work when it is a VPC endpoint. This PR provides a new argument tablestore_instance_name explicitly the instance name to meet
VPC access scenario.

Target Release

1.11.x

Draft CHANGELOG entry

ENHANCEMENTS

  • backend/oss: Adds new arguement tablestore_instance_name used to VPC scenario

@xiaozhu36 xiaozhu36 requested review from a team as code owners January 2, 2025 12:05
@xiaozhu36 xiaozhu36 requested a review from shrhim-des January 2, 2025 12:05
dsa0x
dsa0x previously approved these changes Jan 8, 2025
Copy link
Contributor

@dsa0x dsa0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you

Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify what we mean at line 99?

website/docs/language/backend/oss.mdx Outdated Show resolved Hide resolved
website/docs/language/backend/oss.mdx Outdated Show resolved Hide resolved
@xiaozhu36
Copy link
Contributor Author

@trujillo-adam Exactly. Thanks for your suggestions.

Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good to me!

@trujillo-adam trujillo-adam added the tw-reviewed Technical Writing has reviewed this PR. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend/oss enhancement tw-reviewed Technical Writing has reviewed this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants