-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend/oss: Adds new arguement tablestore_instance_name used to VPC scenario #36253
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify what we mean at line 99?
Co-authored-by: trujillo-adam <[email protected]>
Co-authored-by: trujillo-adam <[email protected]>
@trujillo-adam Exactly. Thanks for your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look good to me!
Terraform State OSS Backend uses Alibaba Cloud Tablestore to store state lock. There needs setting an instance name when putting lock data. Before, the instance name defaults to parsing from argument
tablestore_endpoint
, but it will not work when it is a VPC endpoint. This PR provides a new argument tablestore_instance_name explicitly the instance name to meetVPC access scenario.
Target Release
1.11.x
Draft CHANGELOG entry
ENHANCEMENTS
backend/oss
: Adds new arguement tablestore_instance_name used to VPC scenario