From df130896c43070126a524bf2de80e0f67691eabd Mon Sep 17 00:00:00 2001 From: Jeffrey Cline <20408400+WodansSon@users.noreply.github.com> Date: Fri, 13 Dec 2024 15:43:19 -0700 Subject: [PATCH 1/3] Initial Check-in... --- .../cdn/cdn_frontdoor_profile_data_source.go | 7 + .../cdn_frontdoor_profile_data_source_test.go | 75 +++++ .../cdn/cdn_frontdoor_profile_resource.go | 30 ++ .../cdn_frontdoor_profile_resource_test.go | 265 +++++++++++++++++- .../d/cdn_frontdoor_profile.html.markdown | 12 + .../r/cdn_frontdoor_profile.html.markdown | 13 + 6 files changed, 401 insertions(+), 1 deletion(-) diff --git a/internal/services/cdn/cdn_frontdoor_profile_data_source.go b/internal/services/cdn/cdn_frontdoor_profile_data_source.go index f0e4163e1de1..349f3afb099d 100644 --- a/internal/services/cdn/cdn_frontdoor_profile_data_source.go +++ b/internal/services/cdn/cdn_frontdoor_profile_data_source.go @@ -10,6 +10,7 @@ import ( "github.com/hashicorp/go-azure-helpers/lang/pointer" "github.com/hashicorp/go-azure-helpers/lang/response" "github.com/hashicorp/go-azure-helpers/resourcemanager/commonschema" + "github.com/hashicorp/go-azure-helpers/resourcemanager/identity" "github.com/hashicorp/go-azure-helpers/resourcemanager/tags" "github.com/hashicorp/go-azure-sdk/resource-manager/cdn/2024-02-01/profiles" "github.com/hashicorp/terraform-provider-azurerm/internal/clients" @@ -35,6 +36,8 @@ func dataSourceCdnFrontDoorProfile() *pluginsdk.Resource { "resource_group_name": commonschema.ResourceGroupNameForDataSource(), + "identity": commonschema.SystemAssignedUserAssignedIdentityOptional(), + "response_timeout_seconds": { Type: pluginsdk.TypeInt, Computed: true, @@ -81,6 +84,10 @@ func dataSourceCdnFrontDoorProfileRead(d *pluginsdk.ResourceData, meta interface d.Set("sku_name", string(pointer.From(skuName))) } + if identity, err := identity.FlattenSystemAndUserAssignedMap(model.Identity); err == nil { + d.Set("identity", identity) + } + if props := model.Properties; props != nil { d.Set("response_timeout_seconds", int(pointer.From(props.OriginResponseTimeoutSeconds))) diff --git a/internal/services/cdn/cdn_frontdoor_profile_data_source_test.go b/internal/services/cdn/cdn_frontdoor_profile_data_source_test.go index 1e880d1aec3a..58018aa9535d 100644 --- a/internal/services/cdn/cdn_frontdoor_profile_data_source_test.go +++ b/internal/services/cdn/cdn_frontdoor_profile_data_source_test.go @@ -27,6 +27,51 @@ func TestAccCdnFrontDoorProfileDataSource_basic(t *testing.T) { }) } +func TestAccCdnFrontDoorProfileDataSource_basicWithSystemIdentity(t *testing.T) { + data := acceptance.BuildTestData(t, "data.azurerm_cdn_frontdoor_profile", "test") + d := CdnFrontDoorProfileDataSource{} + + data.DataSourceTest(t, []acceptance.TestStep{ + { + Config: d.basicWithSystemIdentity(data), + Check: acceptance.ComposeTestCheckFunc( + check.That(data.ResourceName).Key("sku_name").HasValue("Standard_AzureFrontDoor"), + check.That(data.ResourceName).Key("identity.0.type").HasValue("SystemAssigned"), + ), + }, + }) +} + +func TestAccCdnFrontDoorProfileDataSource_basicWithUserIdentity(t *testing.T) { + data := acceptance.BuildTestData(t, "data.azurerm_cdn_frontdoor_profile", "test") + d := CdnFrontDoorProfileDataSource{} + + data.DataSourceTest(t, []acceptance.TestStep{ + { + Config: d.basicWithUserIdentity(data), + Check: acceptance.ComposeTestCheckFunc( + check.That(data.ResourceName).Key("sku_name").HasValue("Standard_AzureFrontDoor"), + check.That(data.ResourceName).Key("identity.0.type").HasValue("UserAssigned"), + ), + }, + }) +} + +func TestAccCdnFrontDoorProfileDataSource_basicWithSystemAndUserIdentity(t *testing.T) { + data := acceptance.BuildTestData(t, "data.azurerm_cdn_frontdoor_profile", "test") + d := CdnFrontDoorProfileDataSource{} + + data.DataSourceTest(t, []acceptance.TestStep{ + { + Config: d.basicWithSystemAndUserIdentity(data), + Check: acceptance.ComposeTestCheckFunc( + check.That(data.ResourceName).Key("sku_name").HasValue("Standard_AzureFrontDoor"), + check.That(data.ResourceName).Key("identity.0.type").HasValue("SystemAssigned, UserAssigned"), + ), + }, + }) +} + func (CdnFrontDoorProfileDataSource) basic(data acceptance.TestData) string { return fmt.Sprintf(` %s @@ -37,3 +82,33 @@ data "azurerm_cdn_frontdoor_profile" "test" { } `, CdnFrontDoorProfileResource{}.complete(data)) } + +func (CdnFrontDoorProfileDataSource) basicWithSystemIdentity(data acceptance.TestData) string { + return fmt.Sprintf(` +%s +data "azurerm_cdn_frontdoor_profile" "test" { + name = azurerm_cdn_frontdoor_profile.test.name + resource_group_name = azurerm_cdn_frontdoor_profile.test.resource_group_name +} +`, CdnFrontDoorProfileResource{}.basicWithSystemIdentity(data)) +} + +func (CdnFrontDoorProfileDataSource) basicWithUserIdentity(data acceptance.TestData) string { + return fmt.Sprintf(` +%s +data "azurerm_cdn_frontdoor_profile" "test" { + name = azurerm_cdn_frontdoor_profile.test.name + resource_group_name = azurerm_cdn_frontdoor_profile.test.resource_group_name +} +`, CdnFrontDoorProfileResource{}.basicWithUserIdentity(data)) +} + +func (CdnFrontDoorProfileDataSource) basicWithSystemAndUserIdentity(data acceptance.TestData) string { + return fmt.Sprintf(` +%s +data "azurerm_cdn_frontdoor_profile" "test" { + name = azurerm_cdn_frontdoor_profile.test.name + resource_group_name = azurerm_cdn_frontdoor_profile.test.resource_group_name +} +`, CdnFrontDoorProfileResource{}.basicWithSystemAndUserIdentity(data)) +} diff --git a/internal/services/cdn/cdn_frontdoor_profile_resource.go b/internal/services/cdn/cdn_frontdoor_profile_resource.go index 0fca6291c6c6..07b34d90a7d8 100644 --- a/internal/services/cdn/cdn_frontdoor_profile_resource.go +++ b/internal/services/cdn/cdn_frontdoor_profile_resource.go @@ -10,6 +10,7 @@ import ( "github.com/hashicorp/go-azure-helpers/lang/pointer" "github.com/hashicorp/go-azure-helpers/lang/response" "github.com/hashicorp/go-azure-helpers/resourcemanager/commonschema" + "github.com/hashicorp/go-azure-helpers/resourcemanager/identity" "github.com/hashicorp/go-azure-helpers/resourcemanager/location" "github.com/hashicorp/go-azure-helpers/resourcemanager/tags" "github.com/hashicorp/go-azure-sdk/resource-manager/cdn/2024-02-01/profiles" @@ -50,6 +51,8 @@ func resourceCdnFrontDoorProfile() *pluginsdk.Resource { "resource_group_name": commonschema.ResourceGroupName(), + "identity": commonschema.SystemAssignedUserAssignedIdentityOptional(), + "response_timeout_seconds": { Type: pluginsdk.TypeInt, Optional: true, @@ -107,6 +110,15 @@ func resourceCdnFrontDoorProfileCreate(d *pluginsdk.ResourceData, meta interface Tags: tags.Expand(d.Get("tags").(map[string]interface{})), } + if v, ok := d.GetOk("identity"); ok { + i, err := identity.ExpandSystemAndUserAssignedMap(v.([]interface{})) + if err != nil { + return fmt.Errorf("expanding `identity`: %+v", err) + } + + props.Identity = i + } + err = client.CreateThenPoll(ctx, id, props) if err != nil { return fmt.Errorf("creating %s: %+v", id, err) @@ -143,6 +155,15 @@ func resourceCdnFrontDoorProfileRead(d *pluginsdk.ResourceData, meta interface{} d.Set("sku_name", string(pointer.From(skuName))) } + identity, err := identity.FlattenSystemAndUserAssignedMap(model.Identity) + if err != nil { + return fmt.Errorf("flattening `identity`: %+v", err) + } + + if err := d.Set("identity", identity); err != nil { + return fmt.Errorf("setting `identity`: %+v", err) + } + if props := model.Properties; props != nil { d.Set("response_timeout_seconds", int(pointer.From(props.OriginResponseTimeoutSeconds))) @@ -178,6 +199,15 @@ func resourceCdnFrontDoorProfileUpdate(d *pluginsdk.ResourceData, meta interface props.Properties.OriginResponseTimeoutSeconds = pointer.To(int64(d.Get("response_timeout_seconds").(int))) } + if d.HasChange("identity") { + i, err := identity.ExpandSystemAndUserAssignedMap(d.Get("identity").([]interface{})) + if err != nil { + return fmt.Errorf("expanding `identity`: %+v", err) + } + + props.Identity = i + } + err = client.UpdateThenPoll(ctx, pointer.From(id), props) if err != nil { return fmt.Errorf("updating %s: %+v", *id, err) diff --git a/internal/services/cdn/cdn_frontdoor_profile_resource_test.go b/internal/services/cdn/cdn_frontdoor_profile_resource_test.go index 28ce501fe59f..6713376348bf 100644 --- a/internal/services/cdn/cdn_frontdoor_profile_resource_test.go +++ b/internal/services/cdn/cdn_frontdoor_profile_resource_test.go @@ -34,6 +34,48 @@ func TestAccCdnFrontDoorProfile_basic(t *testing.T) { }) } +func TestAccCdnFrontDoorProfileWithSystemIdentity_basic(t *testing.T) { + data := acceptance.BuildTestData(t, "azurerm_cdn_frontdoor_profile", "test") + r := CdnFrontDoorProfileResource{} + data.ResourceTest(t, r, []acceptance.TestStep{ + { + Config: r.basicWithSystemIdentity(data), + Check: acceptance.ComposeTestCheckFunc( + check.That(data.ResourceName).ExistsInAzure(r), + ), + }, + data.ImportStep(), + }) +} + +func TestAccCdnFrontDoorProfileWithUserIdentity_basic(t *testing.T) { + data := acceptance.BuildTestData(t, "azurerm_cdn_frontdoor_profile", "test") + r := CdnFrontDoorProfileResource{} + data.ResourceTest(t, r, []acceptance.TestStep{ + { + Config: r.basicWithUserIdentity(data), + Check: acceptance.ComposeTestCheckFunc( + check.That(data.ResourceName).ExistsInAzure(r), + ), + }, + data.ImportStep(), + }) +} + +func TestAccCdnFrontDoorProfileWithSystemAndUserIdentity_basic(t *testing.T) { + data := acceptance.BuildTestData(t, "azurerm_cdn_frontdoor_profile", "test") + r := CdnFrontDoorProfileResource{} + data.ResourceTest(t, r, []acceptance.TestStep{ + { + Config: r.basicWithSystemAndUserIdentity(data), + Check: acceptance.ComposeTestCheckFunc( + check.That(data.ResourceName).ExistsInAzure(r), + ), + }, + data.ImportStep(), + }) +} + func TestAccCdnFrontDoorProfile_requiresImport(t *testing.T) { data := acceptance.BuildTestData(t, "azurerm_cdn_frontdoor_profile", "test") r := CdnFrontDoorProfileResource{} @@ -85,6 +127,97 @@ func TestAccCdnFrontDoorProfile_update(t *testing.T) { }) } +func TestAccCdnFrontDoorProfileWithSystemIdentity_update(t *testing.T) { + data := acceptance.BuildTestData(t, "azurerm_cdn_frontdoor_profile", "test") + r := CdnFrontDoorProfileResource{} + data.ResourceTest(t, r, []acceptance.TestStep{ + { + Config: r.complete(data), + Check: acceptance.ComposeTestCheckFunc( + check.That(data.ResourceName).ExistsInAzure(r), + check.That(data.ResourceName).Key("response_timeout_seconds").HasValue("240"), + ), + }, + data.ImportStep(), + { + Config: r.updateWithSystemIdentity(data), + Check: acceptance.ComposeTestCheckFunc( + check.That(data.ResourceName).ExistsInAzure(r), + check.That(data.ResourceName).Key("response_timeout_seconds").HasValue("120"), + ), + }, + data.ImportStep(), + { + Config: r.complete(data), + Check: acceptance.ComposeTestCheckFunc( + check.That(data.ResourceName).ExistsInAzure(r), + check.That(data.ResourceName).Key("response_timeout_seconds").HasValue("240"), + ), + }, + }) +} + +func TestAccCdnFrontDoorProfileWithUserIdentity_update(t *testing.T) { + data := acceptance.BuildTestData(t, "azurerm_cdn_frontdoor_profile", "test") + r := CdnFrontDoorProfileResource{} + data.ResourceTest(t, r, []acceptance.TestStep{ + { + Config: r.complete(data), + Check: acceptance.ComposeTestCheckFunc( + check.That(data.ResourceName).ExistsInAzure(r), + check.That(data.ResourceName).Key("response_timeout_seconds").HasValue("240"), + ), + }, + data.ImportStep(), + { + Config: r.updateWithUserIdentity(data), + Check: acceptance.ComposeTestCheckFunc( + check.That(data.ResourceName).ExistsInAzure(r), + check.That(data.ResourceName).Key("response_timeout_seconds").HasValue("120"), + ), + }, + data.ImportStep(), + { + Config: r.complete(data), + Check: acceptance.ComposeTestCheckFunc( + check.That(data.ResourceName).ExistsInAzure(r), + check.That(data.ResourceName).Key("response_timeout_seconds").HasValue("240"), + ), + }, + }) +} + +func TestAccCdnFrontDoorProfileWithSystemAndUserIdentity_update(t *testing.T) { + data := acceptance.BuildTestData(t, "azurerm_cdn_frontdoor_profile", "test") + r := CdnFrontDoorProfileResource{} + data.ResourceTest(t, r, []acceptance.TestStep{ + { + Config: r.complete(data), + Check: acceptance.ComposeTestCheckFunc( + check.That(data.ResourceName).ExistsInAzure(r), + check.That(data.ResourceName).Key("response_timeout_seconds").HasValue("240"), + ), + }, + data.ImportStep(), + { + Config: r.updateWithSystemAndUserIdentity(data), + Check: acceptance.ComposeTestCheckFunc( + check.That(data.ResourceName).ExistsInAzure(r), + check.That(data.ResourceName).Key("response_timeout_seconds").HasValue("120"), + ), + }, + data.ImportStep(), + { + Config: r.complete(data), + Check: acceptance.ComposeTestCheckFunc( + check.That(data.ResourceName).ExistsInAzure(r), + check.That(data.ResourceName).Key("response_timeout_seconds").HasValue("240"), + ), + }, + data.ImportStep(), + }) +} + func (r CdnFrontDoorProfileResource) Exists(ctx context.Context, clients *clients.Client, state *pluginsdk.InstanceState) (*bool, error) { id, err := profiles.ParseProfileID(state.ID) if err != nil { @@ -119,6 +252,62 @@ resource "azurerm_cdn_frontdoor_profile" "test" { `, template, data.RandomInteger) } +func (r CdnFrontDoorProfileResource) basicWithSystemIdentity(data acceptance.TestData) string { + template := r.template(data) + return fmt.Sprintf(` +provider "azurerm" { + features {} +} +%s +resource "azurerm_cdn_frontdoor_profile" "test" { + name = "acctestprofile-%d" + resource_group_name = azurerm_resource_group.test.name + sku_name = "Standard_AzureFrontDoor" + identity { + type = "SystemAssigned" + } +} +`, template, data.RandomInteger) +} + +func (r CdnFrontDoorProfileResource) basicWithUserIdentity(data acceptance.TestData) string { + template := r.template(data) + return fmt.Sprintf(` +provider "azurerm" { + features {} +} +%s +resource "azurerm_cdn_frontdoor_profile" "test" { + name = "acctestprofile-%d" + resource_group_name = azurerm_resource_group.test.name + sku_name = "Standard_AzureFrontDoor" + identity { + type = "UserAssigned" + identity_ids = [azurerm_user_assigned_identity.test.id] + } +} +`, template, data.RandomInteger) +} + +func (r CdnFrontDoorProfileResource) basicWithSystemAndUserIdentity(data acceptance.TestData) string { + template := r.template(data) + return fmt.Sprintf(` +provider "azurerm" { + features {} +} +%s +resource "azurerm_cdn_frontdoor_profile" "test" { + name = "acctestprofile-%d" + resource_group_name = azurerm_resource_group.test.name + sku_name = "Standard_AzureFrontDoor" + identity { + type = "SystemAssigned, UserAssigned" + identity_ids = [azurerm_user_assigned_identity.test.id] + } +} +`, template, data.RandomInteger) +} + func (r CdnFrontDoorProfileResource) requiresImport(data acceptance.TestData) string { config := r.basic(data) return fmt.Sprintf(` @@ -177,11 +366,85 @@ resource "azurerm_cdn_frontdoor_profile" "test" { `, template, data.RandomInteger) } +func (r CdnFrontDoorProfileResource) updateWithSystemIdentity(data acceptance.TestData) string { + template := r.template(data) + return fmt.Sprintf(` +provider "azurerm" { + features {} +} +%s +resource "azurerm_cdn_frontdoor_profile" "test" { + name = "acctestprofile-%d" + resource_group_name = azurerm_resource_group.test.name + sku_name = "Premium_AzureFrontDoor" + response_timeout_seconds = 120 + identity { + type = "SystemAssigned" + } + tags = { + ENV = "Production" + } +} +`, template, data.RandomInteger) +} + +func (r CdnFrontDoorProfileResource) updateWithUserIdentity(data acceptance.TestData) string { + template := r.template(data) + return fmt.Sprintf(` +provider "azurerm" { + features {} +} +%s +resource "azurerm_cdn_frontdoor_profile" "test" { + name = "acctestprofile-%d" + resource_group_name = azurerm_resource_group.test.name + sku_name = "Premium_AzureFrontDoor" + response_timeout_seconds = 120 + identity { + type = "UserAssigned" + identity_ids = [azurerm_user_assigned_identity.test.id] + } + tags = { + ENV = "Production" + } +} +`, template, data.RandomInteger) +} + +func (r CdnFrontDoorProfileResource) updateWithSystemAndUserIdentity(data acceptance.TestData) string { + template := r.template(data) + return fmt.Sprintf(` +provider "azurerm" { + features {} +} +%s +resource "azurerm_cdn_frontdoor_profile" "test" { + name = "acctestprofile-%d" + resource_group_name = azurerm_resource_group.test.name + sku_name = "Premium_AzureFrontDoor" + response_timeout_seconds = 120 + identity { + type = "SystemAssigned, UserAssigned" + identity_ids = [azurerm_user_assigned_identity.test.id] + } + tags = { + ENV = "Production" + } +} +`, template, data.RandomInteger) +} + func (CdnFrontDoorProfileResource) template(data acceptance.TestData) string { return fmt.Sprintf(` resource "azurerm_resource_group" "test" { name = "acctestRG-cdn-afdx-%d" location = "%s" } -`, data.RandomInteger, data.Locations.Primary) + +resource "azurerm_user_assigned_identity" "test" { + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + name = "acctestAFD-%d" +} +`, data.RandomInteger, data.Locations.Primary, data.RandomInteger) } diff --git a/website/docs/d/cdn_frontdoor_profile.html.markdown b/website/docs/d/cdn_frontdoor_profile.html.markdown index f9b5bb49bd82..653d135ba8c2 100644 --- a/website/docs/d/cdn_frontdoor_profile.html.markdown +++ b/website/docs/d/cdn_frontdoor_profile.html.markdown @@ -27,6 +27,18 @@ The following arguments are supported: * `resource_group_name` - (Required) The name of the Resource Group where this Front Door Profile exists. +* `identity` - (Optional) An `identity` block as defined below. + +--- + +An `identity` block exports the following: + +* `type` - The type of Managed Service Identity that is configured on this Front Door Profile. + +* `identity_ids` - The list of User Assigned Managed Identity IDs assigned to this Front Door Profile. + +--- + ## Attributes Reference The following attributes are exported: diff --git a/website/docs/r/cdn_frontdoor_profile.html.markdown b/website/docs/r/cdn_frontdoor_profile.html.markdown index e7b6835e4b46..6c4557a8d993 100644 --- a/website/docs/r/cdn_frontdoor_profile.html.markdown +++ b/website/docs/r/cdn_frontdoor_profile.html.markdown @@ -39,10 +39,23 @@ The following arguments are supported: * `sku_name` - (Required) Specifies the SKU for this Front Door Profile. Possible values include `Standard_AzureFrontDoor` and `Premium_AzureFrontDoor`. Changing this forces a new resource to be created. +* `identity` - (Optional) An `identity` block as defined below. + * `response_timeout_seconds` - (Optional) Specifies the maximum response timeout in seconds. Possible values are between `16` and `240` seconds (inclusive). Defaults to `120` seconds. * `tags` - (Optional) Specifies a mapping of tags to assign to the resource. + +--- + +An `identity` block supports the following: + +* `type` - (Required) The type of managed identity to assign. Possible values are `SystemAssigned`, `UserAssigned` or `SystemAssigned, UserAssigned`. + +* `identity_ids` - (Optional) - A list of one or more Resource IDs for User Assigned Managed identities to assign. Required when `type` is set to `UserAssigned` or `SystemAssigned, UserAssigned`. + +--- + ## Attributes Reference In addition to the Arguments listed above - the following Attributes are exported: From d1e64287d7ef83881e384d8469455b4fbf894ee0 Mon Sep 17 00:00:00 2001 From: Jeffrey Cline <20408400+WodansSon@users.noreply.github.com> Date: Fri, 13 Dec 2024 16:00:21 -0700 Subject: [PATCH 2/3] terrafmt test cases... --- .../cdn_frontdoor_profile_resource_test.go | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/internal/services/cdn/cdn_frontdoor_profile_resource_test.go b/internal/services/cdn/cdn_frontdoor_profile_resource_test.go index 6713376348bf..e2070e5c60c8 100644 --- a/internal/services/cdn/cdn_frontdoor_profile_resource_test.go +++ b/internal/services/cdn/cdn_frontdoor_profile_resource_test.go @@ -374,9 +374,9 @@ provider "azurerm" { } %s resource "azurerm_cdn_frontdoor_profile" "test" { - name = "acctestprofile-%d" - resource_group_name = azurerm_resource_group.test.name - sku_name = "Premium_AzureFrontDoor" + name = "acctestprofile-%d" + resource_group_name = azurerm_resource_group.test.name + sku_name = "Premium_AzureFrontDoor" response_timeout_seconds = 120 identity { type = "SystemAssigned" @@ -396,9 +396,9 @@ provider "azurerm" { } %s resource "azurerm_cdn_frontdoor_profile" "test" { - name = "acctestprofile-%d" - resource_group_name = azurerm_resource_group.test.name - sku_name = "Premium_AzureFrontDoor" + name = "acctestprofile-%d" + resource_group_name = azurerm_resource_group.test.name + sku_name = "Premium_AzureFrontDoor" response_timeout_seconds = 120 identity { type = "UserAssigned" @@ -419,9 +419,9 @@ provider "azurerm" { } %s resource "azurerm_cdn_frontdoor_profile" "test" { - name = "acctestprofile-%d" - resource_group_name = azurerm_resource_group.test.name - sku_name = "Premium_AzureFrontDoor" + name = "acctestprofile-%d" + resource_group_name = azurerm_resource_group.test.name + sku_name = "Premium_AzureFrontDoor" response_timeout_seconds = 120 identity { type = "SystemAssigned, UserAssigned" @@ -444,7 +444,7 @@ resource "azurerm_resource_group" "test" { resource "azurerm_user_assigned_identity" "test" { resource_group_name = azurerm_resource_group.test.name location = azurerm_resource_group.test.location - name = "acctestAFD-%d" + name = "acctestAFD-%d" } `, data.RandomInteger, data.Locations.Primary, data.RandomInteger) } From b38064996c6d3c9eaa15de7b144708383f3f4b6c Mon Sep 17 00:00:00 2001 From: Jeffrey Cline <20408400+WodansSon@users.noreply.github.com> Date: Wed, 8 Jan 2025 20:51:31 -0700 Subject: [PATCH 3/3] Address PR comments... --- internal/services/cdn/cdn_frontdoor_profile_resource_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/internal/services/cdn/cdn_frontdoor_profile_resource_test.go b/internal/services/cdn/cdn_frontdoor_profile_resource_test.go index e2070e5c60c8..8127d070f906 100644 --- a/internal/services/cdn/cdn_frontdoor_profile_resource_test.go +++ b/internal/services/cdn/cdn_frontdoor_profile_resource_test.go @@ -154,6 +154,7 @@ func TestAccCdnFrontDoorProfileWithSystemIdentity_update(t *testing.T) { check.That(data.ResourceName).Key("response_timeout_seconds").HasValue("240"), ), }, + data.ImportStep(), }) } @@ -184,6 +185,7 @@ func TestAccCdnFrontDoorProfileWithUserIdentity_update(t *testing.T) { check.That(data.ResourceName).Key("response_timeout_seconds").HasValue("240"), ), }, + data.ImportStep(), }) }