Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a separate Go module for cmd/sockaddr #49

Open
dolmen opened this issue May 10, 2023 · 0 comments
Open

Create a separate Go module for cmd/sockaddr #49

dolmen opened this issue May 10, 2023 · 0 comments

Comments

@dolmen
Copy link

dolmen commented May 10, 2023

go-sockaddr is used in HashiCorp core modules such as go-secure-stdlib/parseutil.
go-sockaddr Go module includes cmd/sockaddr which depends on modules used only for this CLI tool. Those features bring their own dependencies which are not needed by the core go-sockaddr functionality.

I propose to drop cmd/sockaddr/vendor and to create a separate Go module for cmd/sockaddr:

cd cmd/sockaddr
go mod init github.com/hashicorp/go-sockaddr/cmd/sockaddr
rm -Rf vendor
go get github.com/hashicorp/[email protected]
go get github.com/mitchellh/[email protected]
go get github.com/mitchellh/[email protected]
go get github.com/ryanuber/[email protected]+incompatible
go get github.com/hashicorp/[email protected]
git add go.mod go.sum
cd ..
go mod tidy
git add go.mod go.sum
git commit -m "Create Go module for cmd/sockaddr"
git tag v1.0.3
git push --tags
cd cmd/sockaddr
go get github.com/hashicorp/[email protected]
go mod tidy
git add go.mod go.sum
git commit
git tag cmd/go-sockaddr/v1.0.3
git push --tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant