Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableNames and Schemas share 'position' abstraction too loosely #76

Open
bhtucker opened this issue Dec 20, 2017 · 1 comment
Open

TableNames and Schemas share 'position' abstraction too loosely #76

bhtucker opened this issue Dec 20, 2017 · 1 comment

Comments

@bhtucker
Copy link
Contributor

bhtucker commented Dec 20, 2017

Summary

We have a position abstraction in logic but not in our objects.

Details

Managed schemas can be promoted from one 'position' to another (ie, staging -> standard, backup -> standard).

TableNames can give their names in 'staging position', which implies a prefix if their schema is a managed schema. However, getting a 'staging' TableName involves setting a private attribute, which is bad.

The same concept as at work here, but is not documented/implemented in a way that makes the connection obvious.

@tvogels01
Copy link
Contributor

This should be a "required" refactoring before we dig into falling back to old data (Issue #75). With the notion of "position" in place, deciding where to copy "old" data from will be more deterministic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants