Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tie requirements.txt file to the Arthur version #600

Open
thomas-vogels opened this issue Nov 18, 2021 · 0 comments
Open

Tie requirements.txt file to the Arthur version #600

thomas-vogels opened this issue Nov 18, 2021 · 0 comments

Comments

@thomas-vogels
Copy link
Contributor

Describe the bug

The upload script that deploys Arthur copies the latest version of the code into S3 while keeping a version number, so for example: dist/redshift_etl-1.56.0.tar.gz. But the file with the requirements for that version is always copied as requirements.txt. That means that an accidental upload of the requirements file or a downgrade of the version leads to the "wrong" requirements file being active.

Expected behavior
The package requirements should be part of the tar ball or a wheel so that we can run something like:

python3 -m pip install arthur-etl

without relying on an un-versioned requirements.txt file.

Additional context

See also: #574
to bring in a process around requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant