Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when using newer systemuicontroller dependency #33

Open
fvito opened this issue Mar 2, 2023 · 2 comments · May be fixed by #34
Open

Crash when using newer systemuicontroller dependency #33

fvito opened this issue Mar 2, 2023 · 2 comments · May be fixed by #34

Comments

@fvito
Copy link

fvito commented Mar 2, 2023

Hello

If target app is using newer version of systemuicontroller from accompanist (anything newer than 0.24.0), then Whats The Stack screen crashes with the following stack trace

Process: com.haroldadmin.crashyapp:what_the_stack_process, PID: 9954
java.lang.NoSuchMethodError: No static method rememberSystemUiController(Landroidx/compose/runtime/Composer;I)Lcom/google/accompanist/systemuicontroller/SystemUiController; in class Lcom/google/accompanist/systemuicontroller/SystemUiControllerKt; or its super classes (declaration of 'com.google.accompanist.systemuicontroller.SystemUiControllerKt' appears in /data/app/~~_4awURteYBFPZaFNkqrgiA==/com.haroldadmin.crashyapp-qVRDMtt8OFur9dGDn3-XHQ==/base.apk)
       at com.haroldadmin.whatthestack.WhatTheStackActivity$onCreate$1.invoke(WhatTheStackActivity.kt:28)
       at com.haroldadmin.whatthestack.WhatTheStackActivity$onCreate$1.invoke(WhatTheStackActivity.kt:27)

It looks like in version 0.25.0 the rememberSystemUiController function signature changed as seen here. It now takes an additional param of a Window, which I think breaks binary compatibility (even though a default is used in the accompanist library)

I think a simple version bump of the dependencies of this library should be enough to fix this issue. I can open a PR if necessary

@haroldadmin
Copy link
Owner

Happy to accept a PR for it! Thank you for investigating the issue.

@fvito fvito linked a pull request Mar 6, 2023 that will close this issue
@fvito
Copy link
Author

fvito commented Mar 6, 2023

Thank you, I've opened a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants