Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the leading blank line in sac.py to comply with PEP8 #845

Open
songyuc opened this issue Feb 10, 2025 · 0 comments
Open

Remove the leading blank line in sac.py to comply with PEP8 #845

songyuc opened this issue Feb 10, 2025 · 0 comments

Comments

@songyuc
Copy link
Contributor

songyuc commented Feb 10, 2025

The file examples/baselines/sac/sac.py contains an unnecessary leading blank line before the first import statement, which does not conform to Python code style guidelines.

Steps to Reproduce

  1. Open examples/baselines/sac/sac.py
  2. Observe the first line of the file

Expected Behavior
The file should start directly with the first import statement from collections import defaultdict without any leading blank lines.

Suggested Fix
Remove the initial blank line to align with PEP8 recommendations:
PEP8 - Module Level Dunder Names states that module-level dunder names should come after any module comments and docstrings, but there's no requirement for leading blank lines before imports.

Additional Context
While this is a minor issue, maintaining a consistent code style improves readability and long-term maintainability. I would be happy to submit a PR to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant