From 5bcc028a9458778fb3c30069b1365bca738448a4 Mon Sep 17 00:00:00 2001 From: fjeagle Date: Tue, 14 May 2024 10:01:45 +0800 Subject: [PATCH] fix #358,#433 [add clientState null check to avoid crash] --- .../java/info/mqtt/android/service/ping/AlarmPingSender.kt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/serviceLibrary/src/main/java/info/mqtt/android/service/ping/AlarmPingSender.kt b/serviceLibrary/src/main/java/info/mqtt/android/service/ping/AlarmPingSender.kt index a47ca314..dd65484a 100755 --- a/serviceLibrary/src/main/java/info/mqtt/android/service/ping/AlarmPingSender.kt +++ b/serviceLibrary/src/main/java/info/mqtt/android/service/ping/AlarmPingSender.kt @@ -29,7 +29,10 @@ internal class AlarmPingSender(val service: MqttService) : MqttPingSender { } override fun start() { - schedule(clientComms!!.keepAlive) + // add clientState null check to avoid ClientState.getKeepAlive() NPE(#358,#433) + clientComms?.clientState?.let { + schedule(clientComms!!.keepAlive) + }?: Timber.e("FIXME: try to start ping schedule, but clientState null, not able to get keepAlive") } override fun stop() {