Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all arrow function event handlers throughout the app #212

Open
nischayv opened this issue Apr 1, 2018 · 0 comments
Open

Remove all arrow function event handlers throughout the app #212

nischayv opened this issue Apr 1, 2018 · 0 comments
Labels
backlog Upcoming issues

Comments

@nischayv
Copy link
Member

nischayv commented Apr 1, 2018

Replace all the inline event handlers in the app. Inline arrow functions are a big NO NO! Use constructor binding instead. Whenever a component re-renders (And react re-renders a lot!), it creates a new arrow function every time and passes it in as the event handler. This will affect the performance of the app.

@nischayv nischayv added the backlog Upcoming issues label Apr 1, 2018
@nischayv nischayv changed the title Remove all inline arrow functions throughout the app Remove all arrow function event handlers throughout the app Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Upcoming issues
Projects
None yet
Development

No branches or pull requests

2 participants