Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run deno tests for every PR, not just /games #950

Open
grymmy opened this issue Mar 10, 2023 · 3 comments
Open

Run deno tests for every PR, not just /games #950

grymmy opened this issue Mar 10, 2023 · 3 comments
Labels
good first issue Good for newcomers tech debt

Comments

@grymmy
Copy link
Contributor

grymmy commented Mar 10, 2023

Suggest always running deno tests to ensure compatibility between the engine and games, not just when something in the /games directory changes.

Commentary can be found here as to why this might be a good idea.
@alhardwarehyde alhardwarehyde moved this to Should we do this? in Sprig Mar 15, 2023
@alhardwarehyde
Copy link
Contributor

@leomcelroy is this something we want to implement?

@leomcelroy
Copy link
Collaborator

Would be great if someone wants to implement it.

@alhardwarehyde alhardwarehyde added good first issue Good for newcomers feature request New Feature or Request labels Mar 15, 2023
@alhardwarehyde alhardwarehyde moved this from Should we do this? to Todo (queue) in Sprig Mar 15, 2023
@kognise kognise changed the title [Tech Debt] Run deno tests for every PR, not just /games Run deno tests for every PR, not just /games Mar 15, 2023
@cuetrigg
Copy link

cuetrigg commented Oct 2, 2023 •
edited
Loading

@alhardwarehyde Can I hack at this?

@grymmy grymmy added tech debt and removed feature request New Feature or Request labels Dec 22, 2023
@itsdoruk itsdoruk removed their assignment Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers tech debt
Projects
Sprig
Status: Todo (queue)
Milestone
No milestone
Development

No branches or pull requests
5 participants
@leomcelroy @grymmy @cuetrigg @alhardwarehyde @itsdoruk