Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why can I not name a game if I'm not logged in? #937

Open
leomcelroy opened this issue Mar 8, 2023 · 3 comments
Open

Why can I not name a game if I'm not logged in? #937

leomcelroy opened this issue Mar 8, 2023 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers low priority

Comments

@leomcelroy
Copy link
Collaborator

leomcelroy commented Mar 8, 2023

Screen Shot 2023-03-08 at 12 31 00 PM

NOTES (by @kognise):

Game name in unsaved draft state should be editable and just go into client-side state, and populate the name field on actual save.

Consideration should probably be made if issue #820 is being worked on concurrently with this one; the game name shouldn't be lost on reload if code is being persisted.

@leomcelroy leomcelroy added this to Sprig Mar 8, 2023
@leomcelroy leomcelroy moved this to Todo (queue) in Sprig Mar 8, 2023
@grymmy grymmy moved this from Todo (queue) to Should we do this? in Sprig Mar 8, 2023
@grymmy grymmy removed the status in Sprig Mar 8, 2023
@alhardwarehyde
Copy link
Contributor

@leomcelroy Can you provide more context on what the issue is?

@alhardwarehyde alhardwarehyde moved this to Should we do this? in Sprig Mar 9, 2023
@leomcelroy
Copy link
Collaborator Author

leomcelroy commented Mar 9, 2023

If logged in I can edit the game name (which is the file name) but if not logged in then I can't and it's locked to Unsaved Game.

@leomcelroy leomcelroy added the bug Something isn't working label Mar 9, 2023
@leomcelroy leomcelroy moved this from Should we do this? to Todo (queue) in Sprig Mar 9, 2023
@leomcelroy leomcelroy removed their assignment Mar 15, 2023
@kognise kognise added the good first issue Good for newcomers label Mar 15, 2023
Copy link
Member

I'm volunteering to work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers low priority
Projects
Status: Todo (queue)
Development

No branches or pull requests

4 participants