Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line numbers broken if multiple game functions in stack trace #891

Open
grymmy opened this issue Mar 2, 2023 · 5 comments
Open

Line numbers broken if multiple game functions in stack trace #891

grymmy opened this issue Mar 2, 2023 · 5 comments
Assignees
Labels
bug Something isn't working medium priority

Comments

@grymmy
Copy link
Contributor

grymmy commented Mar 2, 2023

No description provided.

@kognise kognise added this to Sprig Feb 28, 2023
@grymmy grymmy converted this from a draft issue Mar 2, 2023
@grymmy
Copy link
Contributor Author

grymmy commented Mar 2, 2023

@kognise Can you please add some commentary here that explains this issue?

@grymmy grymmy moved this from Todo (next up) to Todo (queue) in Sprig Mar 2, 2023
@alhardwarehyde alhardwarehyde added the bug Something isn't working label Mar 3, 2023
@alhardwarehyde alhardwarehyde moved this from Todo (queue) to Should we do this? in Sprig Mar 8, 2023
@kognise
Copy link
Member

kognise commented Mar 8, 2023

Stack traces with multiple entries in the game file are incorrectly parsed and thus the line number is miscalculated for all but the first item.

Test case:

function hi() {
  throw new Error('hi')
}

hi()

@samdev-7 samdev-7 moved this from Should we do this? to In Progress in Sprig Mar 11, 2023
@samdev-7 samdev-7 self-assigned this Mar 11, 2023
@alhardwarehyde
Copy link
Contributor

@samdev-7 Just pinging this are you still working on this? If not can you remove the assignment and move this back to the "todo" queue?

@samdev-7
Copy link
Member

I've been trying, but no progress so far. It would be good to move it back to todo.

@samdev-7 samdev-7 removed their assignment Mar 22, 2023
@alhardwarehyde alhardwarehyde moved this from In Progress to Todo (queue) in Sprig Mar 22, 2023
@snoglobe
Copy link
Collaborator

snoglobe commented Apr 1, 2024

gonna take a crack - looks like a big PITA

@snoglobe snoglobe self-assigned this Apr 1, 2024
snoglobe added a commit to snoglobe/sprig that referenced this issue Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working medium priority
Projects
Status: Todo (queue)
Development

No branches or pull requests

6 participants