Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wikipedia Command #120

Closed
wants to merge 2 commits into from
Closed

Wikipedia Command #120

wants to merge 2 commits into from

Conversation

Shivansh-007
Copy link
Contributor

Partially closes #67

This has been implemented with help of aiohttp to request and get json data of the Wikipedia Article. It then filters the data and stores only the required information namely Title, Snippet and Page ID. This filtered data to the Line Paginator.

Screenshot from 2021-04-26 10-35-39

@gustavwilliam
Copy link
Member

I believe you first implemented this for Sir Lancebot, and then added it here?

@Akarys42 what do you think about licensing? Should we mention that it's ported from Sir Lancebot, or is it fine either way, considering that Jason wrote the command? Other people reviewed it as well, so I'm leaning toward attributing Sir Lancebot, if we want to keep this.

@Akarys42
Copy link
Member

I believe you first implemented this for Sir Lancebot, and then added it here?

@Akarys42 what do you think about licensing? Should we mention that it's ported from Sir Lancebot, or is it fine either way, considering that Jason wrote the command? Other people reviewed it as well, so I'm leaning toward attributing Sir Lancebot, if we want to keep this.

Since the code has been given to Python Discord while contributing and other people put time and effort into it through contributions and discussions, it must be attributed to Python Discord with their license.

On another note, I don't see the point is having 80% of this bot be just Python Discord licensed code. If that's really what we want, why aren't we hosting Sir Lancebot and calling it a day?

@Shivansh-007
Copy link
Contributor Author

I thought it would be fine with Licensing, since @gustavwilliam had added the xkcd command the other day, written by Xithrus.

@Shivansh-007
Copy link
Contributor Author

I believe you first implemented this for Sir Lancebot, and then added it here?
@Akarys42 what do you think about licensing? Should we mention that it's ported from Sir Lancebot, or is it fine either way, considering that Jason wrote the command? Other people reviewed it as well, so I'm leaning toward attributing Sir Lancebot, if we want to keep this.

Since the code has been given to Python Discord while contributing and other people put time and effort into it through contributions and discussions, it must be attributed to Python Discord with their license.

On another note, I don't see the point is having 80% of this bot be just Python Discord licensed code. If that's really what we want, why aren't we hosting Sir Lancebot and calling it a day?

Or use the bot as the base, and build upon that with gurkan taste and our commands?

@gustavwilliam
Copy link
Member

That was a rhetorical question. Either way, I'm not convinced we need this command yet. We can discuss it and get back to you later.

@Shivansh-007
Copy link
Contributor Author

@gustavwilliam Any updates?

@gustavwilliam
Copy link
Member

Hi @Shivansh-007! I appreciate that you want to contribute and help make Gurkbot better. However, we don't want it to be primarily based on Sir Lancebot. I'll close this issue, and would love to see some more Gurkbot-exclusive commands in the future 😄

@Shivansh-007 Shivansh-007 deleted the feature/wikipedia-command branch May 12, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition of a new category queries.
3 participants