Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload server emojis and art #3

Open
Vyvy-vi opened this issue Jan 4, 2021 · 11 comments
Open

Upload server emojis and art #3

Vyvy-vi opened this issue Jan 4, 2021 · 11 comments

Comments

@Vyvy-vi
Copy link

Vyvy-vi commented Jan 4, 2021

Description:

Currently, the branding repo is pretty much empty, perhaps we could add the files here so that it could be open for contribution(and display).

Proposed folder structure:

├── emotes
│   ├── base_emojis
│   │   └── gurkmoji_base.svg
│   └── custom_emojis
├── community-logos
│   ├── archive
│   └── current
├── Legal
│   ├── licencing.md
│   └── acknowledgements.md
├── slogans-and-lore
├── LICENSE
├── CONTRIBUTING.md
└── README.md

After this, we could add the emotes inside the repo. Perhaps, we could also try to upload the source files(making them easily editable, and faster to contribute to).
Thoughts? (Is there unnecessary stuff in this folder structure?)

More context: link-to-relevant-discord-chat

@gustavwilliam
Copy link
Member

Yeah, it would be great to get some structure here.

@uncomfyhalomacro
Copy link

uncomfyhalomacro commented Jan 4, 2021

@Vyvy-vi Your proposed structure is clean and intuitive. I do not think there are more to comment but to focus more on what the contents are for each directory. What do you think @gustavwilliam ?

@gustavwilliam
Copy link
Member

I think that it works, generally. There are just a few things we could refine.

I don't see a reason to include a Legal folder. We could put attributions and license-stuff in the README.

community-logos should just be called logos imo. What is the thought behind including an archived section? We have a hit history, so everything we used in the past should be available there.

We can also have sub-directories for the logos. Here are a few options. We can add new sub-folders as we need them.

  • logos/color
  • logos/bw

What's up with the sub-directories inside emotes? We could just have emotes/category, where some examples of categories are:

  • Gurkmoji
  • Other

We could also have an icons category, for icons used by the bot.

@Vyvy-vi
Copy link
Author

Vyvy-vi commented Jan 5, 2021

there's a sub-directory for emoji bases, so that new contributors could pick them up easily, rather than going through the whole gurkmoji list.

Yes, logos would be better and shorter name 👍
The logos/archive is supposed to hold old community logos(in case we change logos in the future and the current sub-directory holds the current ones in use)

I thought about a Legal folder, since this would be opensource art, we might need to write some extra policies etc. especially when contributors edit the existing art, after getting inspired from other art. (I'm not sure about what all legal stuff goes into this)

@gustavwilliam
Copy link
Member

For the archive, we already have fit history if we want the previous logos. I personally don’t see a reason to keep the outdated logos. Maybe @ReneganRonin or someone else has a third view on this?

As for legal, I feel kind of the same way, where I’m not sure if we really need it. If we have a gurkmoji folder, we could probably just shove a license inside the folder, or put it in the readme.

@Akarys42
Copy link
Member

Akarys42 commented Jan 5, 2021

For the archive, we already have fit history if we want the previous logos. I personally don’t see a reason to keep the outdated logos. Maybe ReneganRonin or someone else has a third view on this?

I don’t see any reason for it, we have the git history.

As for legal, I feel kind of the same way, where I’m not sure if we really need it. If we have a gurkmoji folder, we could probably just shove a license inside the folder, or put it in the readme.

I agree, the attributions can just be in the README for third party data.

@uncomfyhalomacro
Copy link

├── emotes
│   ├── base_emojis
│   │   └── gurkmoji_base.svg
│   └── custom_emojis
├── community-logos
│   ├── archive? 
│   └── current?
├── ACKNOWLEDGEMENTS.md
├── slogans-and-lore
├── LICENSE
├── CONTRIBUTING.md
└── README.md

I still like the idea of an archive because even if we have git history, i think it will be a hassle for someone to look for an old svg or image through git history. This is a modified structure @gustavwilliam, what do you think?

@Vyvy-vi
Copy link
Author

Vyvy-vi commented Jan 5, 2021

Maybe, we could replace the archive folder, with a ARCHIVE.md file, that links to the old logos(that might be used by contributors, for inspiration, when making new ones), probably stored in gists/drive/cloud/discord/img-dump/something?

@Akarys42
Copy link
Member

Akarys42 commented Jan 5, 2021 via email

@gustavwilliam
Copy link
Member

Yes, exactly. We should probably do that, if there’s a need for it @Akarys42

@Vyvy-vi
Copy link
Author

Vyvy-vi commented Jan 18, 2021

Yes, I think we could add that in the README 👍
Also, I think maybe we could link to the gurkan_base emoji, from the CONTRIBUTING.md, rather than having a directory for it 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants