Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better continuum pre-processing and/or enable blasé emulator continuum warping by default #67

Open
gully opened this issue Sep 14, 2023 · 0 comments
Open

Better continuum pre-processing and/or enable blasé emulator continuum warping by default #67

gully opened this issue Sep 14, 2023 · 0 comments

Comments

@gully
Copy link
Owner

gully commented Sep 14, 2023

Currently our default is to turn off continuum warping. We should consider turning this back-on, probably by following the example in InstrumentModel. In the long term, we may consider moving to GPs, but for now Polynomials are good enough.

Related issue-- we should do better pre-processing of the input precomputed synthetic model spectra, maybe demand that no peak is greater than say 0.1% above 1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gully