Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle csnx storybooks from central storybooks app #1714

Closed
wants to merge 11 commits into from
Closed

handle csnx storybooks from central storybooks app #1714

wants to merge 11 commits into from

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Sep 25, 2024 •
edited
Loading

What are you changing?

  • all storybooks are built/managed by apps/storybooks
  • typescript imports of react explicitly point to "./node_modules/@types/react"
  • reverts bump of @guardian/ packages peerdep on @types/react which was only there to get storybook working (no longer needed so we can avoid a major bump for consumers)

Why?

keeps the storybook env discreet from the package development environments, meaning we can run storybook in different versions of e.g. react than we develop in. this is a more realistic use of the library.

Co-authored-by: @oliverabrahams

@sndrs
handle csnx storybooks from central storybooks app
496fc70 
this keeps the storybook env discreet from the package development environments
@sndrs
use correct versions
02ef45e
@sndrs
fixes
114a17c
@sndrs
wip
b056d5e
@sndrs
bump storybook
52a126d
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5da6d41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Sep 25, 2024
@sndrs sndrs linked an issue Sep 25, 2024 that may be closed by this pull request
Move storybook to run in a separate app in CSNX #1707
Open
@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added 📦 npm Affects a @guardian package on NPM @guardian/ab-react labels Sep 25, 2024
@sndrs sndrs marked this pull request as ready for review September 27, 2024 11:06
@sndrs sndrs requested review from a team as code owners September 27, 2024 11:06
@sndrs sndrs enabled auto-merge (squash) September 27, 2024 11:06
@github-actions GitHub Actions
Copy link
Contributor

"This PR was marked stale because it has been open for 30 days without activity. If nothing happens, it will be closed 3 days from now."

@github-actions github-actions bot added the Stale label Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

This PR was closed because nothing happened for 3 days after becoming stale.

@github-actions github-actions bot closed this Nov 1, 2024
auto-merge was automatically disabled November 1, 2024 06:05

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
@guardian/ab-react 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move storybook to run in a separate app in CSNX
1 participant
@sndrs