New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetInterval in OBBOBB test #5

Open

bsy6766 opened this issue May 28, 2018 · 0 comments

bsy6766 commented May 28, 2018 •

edited

Loading

I was looking on OBB vs OBB test and found that it's calling GetInterval() with obb1 twice.

GamePhysicsCookbook/Code/Geometry3D.cpp

Lines 384 to 388 in 15810bb

    
           bool OverlapOnAxis(const OBB& obb1, const OBB& obb2, const vec3& axis) { 
        
           	Interval a = GetInterval(obb1, axis); 
        
           	Interval b = GetInterval(obb1, axis); 
        
           	return ((b.min <= a.max) && (a.min <= b.max)); 
        
           }

Is this intentional? or is second call supposed to be with obb2?

Arugin mentioned this issue

Typo in OBBOBB test #13

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment