Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F11 overrides toggle fullscreen binding #8

Open
gsmcmullin opened this issue Oct 23, 2016 · 1 comment
Open

F11 overrides toggle fullscreen binding #8

gsmcmullin opened this issue Oct 23, 2016 · 1 comment
Labels

Comments

@gsmcmullin
Copy link
Owner

@FabianGeiselhart pointed out on #5 :

I think the F11 button is a really bad choice, b/c it toggles the fullscreenmode on most systems...

I know the possibility of creating own keybindings files, but I think overwriting an shortcut as important as F11 is not a good idea anyway...
Using F8, F9, and F10 instead of F9 F10 F11 would be better on my System

The default keybindings are chosen to match those used by Visual Studio Code:
https://code.visualstudio.com/Docs/customization/keybindings#_debug

@esden argued the merits of keeping keys compatible with other tools.

I'm leaving this issue open for comment. If there are strong opinions I'll consider changing the defaults. Users can also reconfigure the keys in Atom using a custom key map.

@esden
Copy link
Contributor

esden commented Oct 23, 2016

As mentioned before, I am against the change, to keep the default bindings compatible to other packages.

Visual Studio: https://msdn.microsoft.com/en-us/library/aa239052(v=vs.60).aspx
Chrome Debugger: https://developers.google.com/web/tools/chrome-devtools/inspect-styles/shortcuts

That is why VSC has similar bindings. I am sure the F11 debugger binding was chosen before full screen key became a thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants