Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI keeps failing #744

Open
bkane-msft opened this issue Jan 16, 2025 · 0 comments
Open

CI keeps failing #744

bkane-msft opened this issue Jan 16, 2025 · 0 comments

Comments

@bkane-msft
Copy link
Contributor

Go version used:

n/a

What happened:

https://github.com/grpc-ecosystem/go-grpc-middleware/actions/runs/12800384294/job/35688069659

Run make lint
  make lint
  shell: /usr/bin/bash -e {0}
  env:
    GOROOT: /opt/hostedtoolcache/go/1.21.13/x64
(re)installing /home/runner/go/bin/buf-v1.26.1
go: downloading github.com/bufbuild/buf v1.26.1
...
(re)installing /home/runner/go/bin/goimports-v0.7.0
...
>> formatting go code
(re)installing /home/runner/go/bin/mdox-v0.9.0
...
 >> generating docs /home/runner/go/bin:/opt/hostedtoolcache/go/1.21.13/x64/bin:/snap/bin:/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
>> lint proto files
>> ensuring copyright headers
cannot set copyright headers: you have unstaged changes.
M	README.md
Please commit or stash them.

What you expected to happen:

The CI to succeed

How to reproduce it (as minimally and precisely as possible):

Open a PR with an empty commit (e.g. #743 )

I think this is happening because the previous commands are modifying the repo before the proto linting, which requires no modifications.

Would it better to move the proto linting before the other changes? Although to be honest, I don't really like that ANYTHING in the CI/CD changes files - I would prefer it simply analyze for issues and require the dev to chang with another PR.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant