Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open in Safari" button doesn't work in thread view #106

Open
HyShai opened this issue Mar 24, 2013 · 2 comments
Open

"Open in Safari" button doesn't work in thread view #106

HyShai opened this issue Mar 24, 2013 · 2 comments

Comments

@HyShai
Copy link

HyShai commented Mar 24, 2013

The "Open in Safari" button doesn't work in thread view. The menu acts as though it has been pressed and slides away, but the action doesn't fire and no Safari window opens. The button works as expected in other areas of the app.

IMG-20130323223000

@hpsoar
Copy link

hpsoar commented Jul 25, 2013

in LoadingController, use absoluteURL

  • (void)actionTapped {
    SharingController *sharingController = [[SharingController alloc] initWithURL:[source URL].absoluteURL title:[self sourceTitle] fromController:self];
    [sharingController showFromBarButtonItem:actionItem];
    [sharingController release];
    }

alexfish added a commit to alexfish/newsyc that referenced this issue Sep 17, 2013
* Copying the absoulte URL in SharingController initWithURL: method
grp added a commit that referenced this issue Nov 9, 2013
Fixing issue #106 - Copying URLs absoluteURL in SharingController
@alexfish
Copy link
Contributor

alexfish commented Nov 9, 2013

This is fixed now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants