-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSPM Install Does not create js file to import #21
Comments
A work around from stackoverflow is to use .feature("aurelia-chart"); rather than .plugin("aurelia-chart"); http://stackoverflow.com/questions/38695467/pluginaurelia-chart-throws-404-error |
This has been mentioned a few times there is a distinction between There should be an |
No, aurelia-chart.js hasn't turned up in the dist directory. The loader tries to load jspm_packages/npm/[email protected] but that doesn't exist either. I've got JSPM 0.16.47 running. |
Can you screenprint or tell me what is in your JSPM folder for the |
|
hmm that is very odd as the dist folders which the package.json should be linked to output https://github.com/grofit/aurelia-chart/tree/master/dist/system So to my knowledge that is what the jspm should be using, does anyone else have this issue? (I have lost weeks of my life to the aurelia tooling stuff so I am often reluctant to spend more time on it unless knowing there is a specific problem which wont somehow break it for others, which is often the case). |
@grofit did you actually update the npm package after importing my pull request into github? It appears as no, can you check as the version on github is 0.2.6 (as per my pull request) but here is 0.2.5 listed. |
I cannot remember, I will clone it all and give it a whirl now as there is another PR which needs to be built and released. |
I think this issue could be linked as duplicate #15 |
… making sure the binding changes in #22 are released.
Right I have done a new release, ran it all locally and it works, I did notice that for some reason it was back to being index but referencing the aurelia-chart.js, I dont remember who made that change as I think I always had it as index, anyway it should all work in 0.2.6 which is also released on NPM so please give that a try and let me know if it fixes this issue. |
I'm afraid that didn't fix it. I still get a 404 as the browser tries to load jspm_packages/npm/[email protected] I did get a warning as JSPM was updating the package:
|
@pierslawson can you try to install from my repo just for test: "jspm install github:urosg80/aurelia-chart" as this was working before. |
AH ok, so can anyone confirm does JSPM need its OWN https://github.com/grofit/aurelia-chart/blob/master/package.json#L13 There is the one for the latest version so as you can see there is a main in there that references the correct file. |
I am guessing that the problem is in the "index.js" file names as when I was testing for my fix only after renaming the index.js files to aurelia-chart.js and fixing the references then JSPM installation worked. |
ah so it was you who renamed them, I couldnt care less what the names were, but when I pulled latest and gulped it renamed them all back to index and it seemed ok. |
@urosg80 I tried your branch as suggested and get the same issue when trying the use.plugin call as opposed to the feature call:
|
Sorry, didn't mean to close this |
@pierslawson I had the same issues but if I add the following lines to config.js it seems to work fine.: |
We do that on the example to fudge JSPM to load the module locally, but you should not need to do that normally, ultimately its a JSPM related issue, if someone can show me or do a PR with the desired JSPM config that will load it all correctly I will get it added. |
can someone please try install from my npm package: "jspm install npm:aurelia-ugchart" (https://www.npmjs.com/package/aurelia-ugchart) it's the 0.2.5 version prepared for my previous PR as it seems to me that JSPM is quite picky for installation depending on source (npm, git, ...) |
didnt @pierslawson try your branch and got the same issue? |
yes, but from github and this is why I suspect that JSPM is handling installation differently depending on source and would just like to double check as it worked for me when installing from npm and why I then submitted the PR |
@urosg80 I've installed your package and didn't get any install warnings... however the package has not actually been installed in the JSPM directory... I'll try again. This was the information spat out by JSPM as I installed
|
lol the plot thickens |
OK... I tried to uninstall and was given the message:
So I manually deleted it from package.json and config.js. I installed again and the sub-directory was created and the |
@grofit as you can see the PR I prepared before works and as I suspected JPSM handles installation from different sources differently i.e. source from npm installs but from github not although the actual files are the same... "interesting" ;) |
just to confirm when you use the official npm repo for this If it is down to the way JSPM handles this I think its something to be discussed with JSPM guys but I dont really have capacity to chase those guys down again, so if anyone else is in that domain and fancies picking it up with them go for it. |
Around a month ago I was able to resolve this issue by installing from master instead of the regular release. However, since you have made the change to "fix" this problem for release, I have no longer been able to use this work-around. The latest release does not resolve the issue either. |
I am still having this issue as well. I've tried installing the package in the following ways: Regardless of my installation method, there is never an "aurelia-chart.js" inside of the package directory, as there should be, and I receive the aforementioned "404 not found" error upon loading my aurelia app. EDIT: As noted below, "jspm install npm:aurelia-ugchart" works fine. |
@JesseNewman19 please try also and report: |
@urosg80 That one worked for me, thanks. |
by all means @urosg80 do another PR with the current version to make it work (making sure the demos still work too). |
I couldn't get this to work in my app (the same 404 as above) so I setup a fresh app via the skeleton-esnext (1.1.1), ran:
added: and the added aura-ugchart to bundles.js
and that all seems ok when run locally with gulp watch. If I use gulp export and then run it on my remote server I get 404: GET http://www.[].com/jspm_packages/npm/[email protected] 404 (Not Found) I confess I'm new to JSPM and gulp - so feel free to point out any blindingly obvious omissions I've made.... Thanks |
Do we have a status on this working w/JSPM? |
current status is: If someone with more knowledge of JSPM than I can fix this and do a PR it will be solved, I am not actively looking into it as its been fixed multiple times then breaks again for some reason, so I am not sinking any more time into it. |
aurelia-chart version: 0.2.7 The following worked for me:
|
|
Although this should be fixed, @grofit, |
@JoshMcCullough Yes, bundles.js is the file used to configure the output, e.g when doing a gulp export. I think only the config.js part needs to be fixed. For other plugins, just referencing the plugin name in bundles.js knows about its own main js file. Maybe renaming index.js to aurelia-chart.js might fix the issue |
Sorry if I am a bit simple here but where is this |
@grofit from aurelia-skeleton : I don't know if this is something you can add. It should rather be part of your ReadMe/Documention |
That |
I believe this is the solution: https://jspm.io/0.17-beta-guide/overrides.html jspm install npm:aurelia-chart -o "{main: 'index.js'}" |
I have installed Aurelia-chart using your JSPM instructions and it has turned up in my package.json and config.js files OK. The files are also present in a [email protected] directory under my jspm_packages/npm directory. However, for other packages I see a corresponding js file in the jspm_packages/npm directory, but there isn't a [email protected] file created. So when my application runs I get a 404 as the browser tries to load jspm_packages/npm/[email protected]
I wondering if I have missed a step?
The text was updated successfully, but these errors were encountered: