expanded cannot be changed when children is null

[joechrz]

This code fails:

descriptor.children = null;
descriptor.expanded = false;

because the expanded setter will early-exit if no children are present. the code needs to be:

descriptor.expanded = false;
descriptor.children = null;

https://github.com/gridgrid/grid/blob/master/src/modules/abstract-row-col-model/index.js#L316
^it seems this should only early exit when trying to set expanded to true when no children are present.

[scamden]

i think you're right feel free to submit a pr against the v4 branch to fix this

[scamden]

actually i think this reveals a larger bug that any change to children must be done while not expanded. any other change to children while expanded will cause some... problems

[scamden]

i'm unfortunately gonna have to put this one off a little while given the scope of the fix