-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows binaries throwing potentially false positives for Win security features #146
Comments
Doing some further testing, it seems that Action builds on |
The initial SmartScreen warning is to be expected because it's an unsigned binary. The virus detection I haven't seen before, and I can't reproduce it here. I've tried the latest CI #602, as well as the CI #503 build that you mentioned, and both install and run without alerts after selecting 'More Info' / 'Run Anyway' for the initial SmartScreen warning. I'm also on Windows 10.0.19045, with the virus & threat protection database updated just now. So I see a couple of possibilities:
Searching for If updating doesn't eliminate the detections, it would be interesting to see the |
From CI #595 |
Interesting - CI #600 was triggered by the merge of PR #141. That PR did fix us doing things a little unusually for a GTK app, so maybe it saw that as suspicious, and now we're doing things in the more standard way it's less worried. |
Interestingly enough, it started to do this on newer CIs as well. |
I'm still not able to reproduce this here. Just tried the latest CI #620. Windows reports that it's using:
|
Yeah, I'm not sure what the issue is. I'm going to chalk it up to a false positive and do some digging on my machine. Nothing else seems to be triggering this behavior on my end, and I don't want to make it seem like the program is the issue without solid evidence. Just wanted to provide info in case something upstream may have been an issue. |
I'm going to close this issue since I gather from Discord that you got things working, and without a way for us to reproduce the detection I don't think there's anything else we can do here. If you or anyone else encounters this again, feel free to reopen. |
I've just experienced "Couldn't download - Virus detected" while trying to download the Windows installer from https://github.com/greatscottgadgets/packetry/actions/runs/10322277671/artifacts/1795741895 (#166). Windows Defender thinks it is |
We are not the first to have this problem: https://answers.microsoft.com/en-us/windows/forum/all/overly-eager-heuristics-for-trojanwin32wacatacbml/6f2a72f3-3978-48ac-9fb7-fbe82c686ae3 Sounds like "machine learning" has probably learned to recognize one of our dependencies because it is also a dependency of some malware. |
I did
and got the same trojan detection. |
I think we have to consider whether this is our problem to solve. This is an open source project for which every single line of code, as well as all the CI infrastructure for building it, is all available for everyone to inspect, reproduce and verify for themselves that it is free from malicious behaviour. If someone trains a machine learning model to identify malicious code, and that model flags our binaries as malicious, then that is the absolute definition of a false positive, and the problem is with the model. If the detection came with some details of which aspects of the binary were considered suspicious, then we would at least have the option of altering our code to avoid triggering that particular false positive. However, for obvious reasons, the report doesn't reveal anything about the detection method. As such, there really is nothing we can do. The bug to be reported here is against the detection system. |
When I try to use the zipped installer from the 0.1.0 release, it returns a Microsoft Defender SmartScreen prompt (image 1). As a precaution, I also tried to test the latest CI build from main's actions. On completed download, this binary triggers a Defender trojan detection (image 2). I could download the
Binary for windows-latest.zip
file, but it's a little concerning when both bundled installers are throwing potential virus warnings.OS Name: Microsoft Windows 10 Pro
Version: 10.0.19045 Build 19045
The text was updated successfully, but these errors were encountered: