Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in settings.c #538

Open
andrewmarles opened this issue Jun 21, 2024 · 1 comment
Open

Typo in settings.c #538

andrewmarles opened this issue Jun 21, 2024 · 1 comment

Comments

@andrewmarles
Copy link
Contributor

I think that on lines 2010 and lines 2023 that the bang should not be prefixed on the call to spindle_get_caps:

core/settings.c

Line 2010 in 9a060d7

available = hal.signals_cap.safety_door_ajar && spindle_get_count() && !spindle_get_caps(true).at_speed;

core/settings.c

Line 2023 in 9a060d7

available = !hal.signals_cap.safety_door_ajar && spindle_get_count() && !spindle_get_caps(true).at_speed;

I think they should be

available = hal.signals_cap.safety_door_ajar && spindle_get_count() && spindle_get_caps(true).at_speed;

Otherwise the spindles with speed feedback all return false on this check.

@terjeio
Copy link
Contributor

terjeio commented Jun 22, 2024

This gets complicated when more than one spindle (not counting spindles that are not spinning) is configured and not all are at speed capable since the value is used as the timeout for at speed capable spindles. I guess a new setting for the timeout is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants