diff --git a/CHANGELOG.md b/CHANGELOG.md index 039b93d0c0..c3cab8fd7f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -28,6 +28,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - [#1419](https://github.com/nf-core/sarek/pull/1419) - Updating GATK to v4.5, and updating samtools to v1.19.2 in GATK/markduplicates. - [#1426](https://github.com/nf-core/sarek/pull/1426) - Updating certain modules in order to fix the testdata-path in the nf-tests of those modules. Setting Docker runOptions for params.use_gatk_spark. - [#1428](https://github.com/nf-core/sarek/pull/1428) - Sync `TEMPLATE` with `tools` `2.13.1` +- [#1431](https://github.com/nf-core/sarek/pull/1431) - Using docker.containerOptions instead of docker.runOptions. Clearing containerOptions for SPARK modules for any kind of supported container engine. ### Fixed diff --git a/conf/modules/markduplicates.config b/conf/modules/markduplicates.config index c33b6a3a2a..55f29ede51 100644 --- a/conf/modules/markduplicates.config +++ b/conf/modules/markduplicates.config @@ -91,6 +91,7 @@ process { } withName: 'GATK4SPARK_MARKDUPLICATES' { + containerOptions = '' ext.args = { '--remove-sequencing-duplicates false -VS LENIENT' } ext.prefix = { "${meta.id}.md.cram" } publishDir = [ diff --git a/conf/modules/prepare_recalibration.config b/conf/modules/prepare_recalibration.config index 915075d5b4..a0f7bfbdb2 100644 --- a/conf/modules/prepare_recalibration.config +++ b/conf/modules/prepare_recalibration.config @@ -16,6 +16,9 @@ process { withName: 'GATK4_BASERECALIBRATOR|GATK4SPARK_BASERECALIBRATOR' { + if (params.use_gatk_spark) { + containerOptions = '' + } ext.prefix = { meta.num_intervals <= 1 ? "${meta.id}.recal" : "${meta.id}_${intervals.simpleName}.recal" } publishDir = [ mode: params.publish_dir_mode, diff --git a/conf/modules/recalibrate.config b/conf/modules/recalibrate.config index 41aa3a4146..19bbb17d35 100644 --- a/conf/modules/recalibrate.config +++ b/conf/modules/recalibrate.config @@ -16,6 +16,9 @@ process { withName: 'GATK4_APPLYBQSR|GATK4SPARK_APPLYBQSR' { + if (params.use_gatk_spark) { + containerOptions = '' + } ext.prefix = { meta.num_intervals <= 1 ? "${meta.id}.recal" : "${meta.id}_${intervals.baseName}.recal" } publishDir = [ mode: params.publish_dir_mode, diff --git a/conf/test.config b/conf/test.config index 002b35d183..9954873561 100644 --- a/conf/test.config +++ b/conf/test.config @@ -108,7 +108,7 @@ if (System.getenv('PROFILE')) { } else if ("$PROFILE" == "docker") { conda.enabled = false docker.enabled = true - docker.runOptions = { params.use_gatk_spark ? '' : '-u $(id -u):$(id -g)' }.call() + process.containerOptions = '-u $(id -u):$(id -g)' charliecloud.enabled = false podman.enabled = false shifter.enabled = false diff --git a/conf/test/cache.config b/conf/test/cache.config index 5aba7dc0f6..a768caad28 100644 --- a/conf/test/cache.config +++ b/conf/test/cache.config @@ -116,7 +116,7 @@ if (System.getenv('PROFILE')) { } else if ("$PROFILE" == "docker") { conda.enabled = false docker.enabled = true - docker.runOptions = { params.use_gatk_spark ? '' : '-u $(id -u):$(id -g)' }.call() + process.containerOptions = '-u $(id -u):$(id -g)' charliecloud.enabled = false podman.enabled = false shifter.enabled = false diff --git a/conf/test/use_gatk_spark.config b/conf/test/use_gatk_spark.config index 41bbc16452..bd40af1b77 100644 --- a/conf/test/use_gatk_spark.config +++ b/conf/test/use_gatk_spark.config @@ -14,5 +14,3 @@ params { use_gatk_spark = 'baserecalibrator,markduplicates' input = "${projectDir}/tests/csv/3.0/fastq_tumor_only.csv" } - -docker.runOptions = '' diff --git a/nextflow.config b/nextflow.config index 25ab62c66f..e9dabd1136 100644 --- a/nextflow.config +++ b/nextflow.config @@ -186,17 +186,17 @@ profiles { singularity.enabled = false } docker { - apptainer.enabled = false - charliecloud.enabled = false - conda.enabled = false - docker.enabled = true - podman.enabled = false - shifter.enabled = false - docker.runOptions = { params.use_gatk_spark ? '' : '-u $(id -u):$(id -g)' }.call() - singularity.enabled = false + apptainer.enabled = false + charliecloud.enabled = false + conda.enabled = false + docker.enabled = true + podman.enabled = false + shifter.enabled = false + process.containerOptions = '-u $(id -u):$(id -g)' + singularity.enabled = false } arm { - docker.runOptions = '-u $(id -u):$(id -g) --platform=linux/amd64' + process.containerOptions = '-u $(id -u):$(id -g) --platform=linux/amd64' } singularity { apptainer.enabled = false