Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Fix panic while exporting a nil Goja value #1204

Closed
2 tasks done
inancgumus opened this issue Feb 2, 2024 · 0 comments · Fixed by #1205
Closed
2 tasks done

Fix panic while exporting a nil Goja value #1204

inancgumus opened this issue Feb 2, 2024 · 0 comments · Fixed by #1205
Assignees
@inancgumus
Labels
bug Something isn't working mapping k6 browser to Goja mapping related.

Comments

@inancgumus
Copy link
Member

inancgumus commented Feb 2, 2024 •
edited
Loading

What?

When running the script in #1089 it panics with an NPD.

Last commit: 12ab6e9

Why

To prevent panics while calling browser methods with null or undefined values.

How?

  • We need to check for nil here before exporting goja.Value types.
  • This should also be checked for the other options that export.

Tasks

Tasks
Preview Give feedback
  1. Fix 1204: panic while exporting nil sobek values #1205
    inancgumus
  2. Add browser#1205 to release notes k6#3584

Related PR(s)/Issue(s)

#1182
@inancgumus inancgumus added bug Something isn't working mapping k6 browser to Goja mapping related. labels Feb 2, 2024
@inancgumus inancgumus self-assigned this Feb 2, 2024
@inancgumus inancgumus mentioned this issue Feb 2, 2024
Merged
3 tasks
@inancgumus inancgumus reopened this Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@inancgumus inancgumus

Labels
bug Something isn't working mapping k6 browser to Goja mapping related.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 1204: panic while exporting nil sobek values grafana/xk6-browser
1 participant
@inancgumus