Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make update command broken #75

Closed
madig opened this issue May 18, 2022 · 2 comments
Closed

make update command broken #75

madig opened this issue May 18, 2022 · 2 comments

Comments

@madig
Copy link
Contributor

madig commented May 18, 2022

The Makefile contains

pip install --upgrade $(dependency); pip freeze > requirements.txt

but the $(dependency) variable is undefined. Running pip then crashes (after activating the venv, which isn't done like in the build command):

pip install --upgrade ; pip freeze > requirements.txt
ERROR: You must give at least one requirement to install (see "pip help install")

I also find the in-place updating of requirements a bit unfortunate. It perpetuates dependencies even if they're not used anymore because the primary/transient distinction gets lost. A cleaner way would be to have a file requirements.in:

fontmake>=2.4
fontbakery>=0.8
gftools[qa]>=0.7
drawbot-skia>=0.4.8
sh>=1.14.2
bumpfontversion>=0.2.0

and use pip-compile requirements.in (https://github.com/jazzband/pip-tools) to generate the actual requirements.txt with all pinned deps.

@wayne-shih
Copy link

I had a similar issue but via workflow actions
As an interim workaround I changed my requirements.txt to a previously (known stable, at least for me) generated file
requirements.txt

major version changes in requirements.txt from previous stable to new generated...

-    cattrs==1.10.0
-    certifi==2021.10.8
+    cattrs==22.1.0
+    certifi==2022.5.18.1

     ...

-    exceptiongroup==1.0.0rc7

     ...

-    protobuf==3.20.1
+    protobuf==4.21.1

wonder if there's any breaking changes in those deps that's causing the issue.
on a side note, also noticed exceptiongroup got removed in the new generated req txt

@simoncozens
Copy link
Contributor

Thank you for the PR; I finished it off in #169.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants