Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Codegen should have a default FIFO implementation #1813

Open
grebe opened this issue Dec 26, 2024 · 1 comment
Open

[enhancement] Codegen should have a default FIFO implementation #1813

grebe opened this issue Dec 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@grebe
Copy link
Collaborator

grebe commented Dec 26, 2024

What's hard to do? (limit 100 words)

Currently you need to provide a FIFO implementation or set the --materialize_internal_fifos flag if you use multi-proc codegen or loopback channels. Without doing one of these things, you'll have FIFO instantiations with no module definitions.

Related: #1667.

Current best alternative workaround (limit 100 words)

Provide a FIFO implementation or set --materialize_internal_fifos.

Your view of the "best case XLS enhancement" (limit 100 words)

We should move our default to --materialize_internal_fifos or provide a good default FIFO implementation.

@grebe grebe added the enhancement New feature or request label Dec 26, 2024
@ericastor
Copy link
Collaborator

This got a bit worse after commit 4b262b0, since now this affects even depth=0 FIFOs; in fact, a few examples in this repository broke without us noticing, including our RAM-based delay example!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants