[Type verification] What is the expectation if user's API call sent wrong type? Such as adult = "A String False".

[Solodye]

For example, if in here, user sent API call that adult = "A String False"

shoptimizer/shoptimizer_api/optimizers_builtin/adult_optimizer.py

Line 89 in a9fff3a

is_adult = product.get('adult', False)

Then in here the UT will fail, as shoptimizer will send string "False" directly outside.

shoptimizer/shoptimizer_api/optimizers_builtin/adult_optimizer_test.py

Line 273 in a9fff3a

def test_adult_optimizer_does_nothing_if_adult_tokens_in_description_but_category_is_not_adult(

Because in Python3, if not "any string" its value will be False in boolean. Then this will cause all these two if being passed

1. Passed
   

   shoptimizer/shoptimizer_api/optimizers_builtin/adult_optimizer.py

   Line 92 in a9fff3a

   if not is_adult and self._is_product_type_adult(product_types):

2. Passed
   

   shoptimizer/shoptimizer_api/optimizers_builtin/adult_optimizer.py

   Line 101 in a9fff3a

   elif not is_adult and category_specific_tokens:

Then shoptimizer don't think its adult field need to change or santinize.

Just ask, is this phenomenon within the expectation?