From b0776d7ece194fd3d0f6e426d48442a3c9a1f429 Mon Sep 17 00:00:00 2001 From: Justin Fagnani Date: Mon, 19 Aug 2024 13:19:42 -0700 Subject: [PATCH] Remove puppeteer --- package-lock.json | 123 -------------------------------------- package.json | 1 - web-test-runner.config.js | 9 --- 3 files changed, 133 deletions(-) diff --git a/package-lock.json b/package-lock.json index 4e12e1f9..2531c789 100644 --- a/package-lock.json +++ b/package-lock.json @@ -36,7 +36,6 @@ "@web/dev-server": "^0.4.6", "@web/test-runner": "^0.18.3", "@web/test-runner-playwright": "^0.11.0", - "@web/test-runner-puppeteer": "^0.16.0", "clean-css": "^5.1.2", "codemirror": "^5.65.9", "codemirror-grammar-mode": "^0.1.10", @@ -2192,21 +2191,6 @@ "node": ">=18.0.0" } }, - "node_modules/@web/test-runner-puppeteer": { - "version": "0.16.0", - "resolved": "https://registry.npmjs.org/@web/test-runner-puppeteer/-/test-runner-puppeteer-0.16.0.tgz", - "integrity": "sha512-/p8zG+FX3LZjJttjQBqEigfGpnoUyEeNXrYReQWT4Uqj16Zm5F7I0UVecmBCRjnplUoXXlNcZNMsXb0jXBucTw==", - "dev": true, - "license": "MIT", - "dependencies": { - "@web/test-runner-chrome": "^0.16.0", - "@web/test-runner-core": "^0.13.0", - "puppeteer": "^22.0.0" - }, - "engines": { - "node": ">=18.0.0" - } - }, "node_modules/accepts": { "version": "1.3.8", "resolved": "https://registry.npmjs.org/accepts/-/accepts-1.3.8.tgz", @@ -3313,33 +3297,6 @@ "node": ">= 0.8" } }, - "node_modules/cosmiconfig": { - "version": "9.0.0", - "resolved": "https://registry.npmjs.org/cosmiconfig/-/cosmiconfig-9.0.0.tgz", - "integrity": "sha512-itvL5h8RETACmOTFc4UfIyB2RfEHi71Ax6E/PivVxq9NseKbOWpeyHEOIbmAw1rs8Ak0VursQNww7lf7YtUwzg==", - "dev": true, - "license": "MIT", - "dependencies": { - "env-paths": "^2.2.1", - "import-fresh": "^3.3.0", - "js-yaml": "^4.1.0", - "parse-json": "^5.2.0" - }, - "engines": { - "node": ">=14" - }, - "funding": { - "url": "https://github.com/sponsors/d-fischer" - }, - "peerDependencies": { - "typescript": ">=4.9.5" - }, - "peerDependenciesMeta": { - "typescript": { - "optional": true - } - } - }, "node_modules/cross-spawn": { "version": "7.0.3", "resolved": "https://registry.npmjs.org/cross-spawn/-/cross-spawn-7.0.3.tgz", @@ -3840,26 +3797,6 @@ "url": "https://github.com/fb55/entities?sponsor=1" } }, - "node_modules/env-paths": { - "version": "2.2.1", - "resolved": "https://registry.npmjs.org/env-paths/-/env-paths-2.2.1.tgz", - "integrity": "sha512-+h1lkLKhZMTYjog1VEpJNG7NZJWcuc2DDk/qsqSTRRCOXiLjeQ1d1/udrUGhqMxUgAlwKNZ0cf2uqan5GLuS2A==", - "dev": true, - "license": "MIT", - "engines": { - "node": ">=6" - } - }, - "node_modules/error-ex": { - "version": "1.3.2", - "resolved": "https://registry.npmjs.org/error-ex/-/error-ex-1.3.2.tgz", - "integrity": "sha512-7dFHNmqeFSEt2ZBsCriorKnn3Z2pj+fd9kmI6QoWw4//DL+icEBfc0U7qJCisqrTsKTjw4fNFy2pW9OqStD84g==", - "dev": true, - "license": "MIT", - "dependencies": { - "is-arrayish": "^0.2.1" - } - }, "node_modules/errorstacks": { "version": "2.4.1", "resolved": "https://registry.npmjs.org/errorstacks/-/errorstacks-2.4.1.tgz", @@ -5347,13 +5284,6 @@ "url": "https://github.com/sponsors/ljharb" } }, - "node_modules/is-arrayish": { - "version": "0.2.1", - "resolved": "https://registry.npmjs.org/is-arrayish/-/is-arrayish-0.2.1.tgz", - "integrity": "sha512-zz06S8t0ozoDXMG+ube26zeCTNXcKIPJZJi8hBrF4idCLms4CG9QtK7qBl1boi5ODzFpjswb5JPmHCbMpjaYzg==", - "dev": true, - "license": "MIT" - }, "node_modules/is-bigint": { "version": "1.0.4", "resolved": "https://registry.npmjs.org/is-bigint/-/is-bigint-1.0.4.tgz", @@ -5820,13 +5750,6 @@ "integrity": "sha512-4bV5BfR2mqfQTJm+V5tPPdf+ZpuhiIvTuAB5g8kcrXOZpTT/QwwVRWBywX1ozr6lEuPdbHxwaJlm9G6mI2sfSQ==", "dev": true }, - "node_modules/json-parse-even-better-errors": { - "version": "2.3.1", - "resolved": "https://registry.npmjs.org/json-parse-even-better-errors/-/json-parse-even-better-errors-2.3.1.tgz", - "integrity": "sha512-xyFwyhro/JEof6Ghe2iz2NcXoj2sloNsWr/XsERDK/oiPCfaNhl5ONfp+jQdAZRQQ0IJWNzH9zIZF7li91kh2w==", - "dev": true, - "license": "MIT" - }, "node_modules/json-schema-traverse": { "version": "0.4.1", "resolved": "https://registry.npmjs.org/json-schema-traverse/-/json-schema-traverse-0.4.1.tgz", @@ -6043,13 +5966,6 @@ "node": ">=14" } }, - "node_modules/lines-and-columns": { - "version": "1.2.4", - "resolved": "https://registry.npmjs.org/lines-and-columns/-/lines-and-columns-1.2.4.tgz", - "integrity": "sha512-7ylylesZQ/PV29jhEDl3Ufjo6ZX7gCqJr5F7PKrqc93v7fzSymt1BpwEU8nAUXs8qzzvqhbjhK5QZg6Mt/HkBg==", - "dev": true, - "license": "MIT" - }, "node_modules/lit": { "version": "2.8.0", "resolved": "https://registry.npmjs.org/lit/-/lit-2.8.0.tgz", @@ -6689,25 +6605,6 @@ "node": ">=6" } }, - "node_modules/parse-json": { - "version": "5.2.0", - "resolved": "https://registry.npmjs.org/parse-json/-/parse-json-5.2.0.tgz", - "integrity": "sha512-ayCKvm/phCGxOkYRSCM82iDwct8/EonSEgCSxWxD7ve6jHggsFl4fZVQBPRNgQoKiuV/odhFrGzQXZwbifC8Rg==", - "dev": true, - "license": "MIT", - "dependencies": { - "@babel/code-frame": "^7.0.0", - "error-ex": "^1.3.1", - "json-parse-even-better-errors": "^2.3.0", - "lines-and-columns": "^1.1.6" - }, - "engines": { - "node": ">=8" - }, - "funding": { - "url": "https://github.com/sponsors/sindresorhus" - } - }, "node_modules/parse5": { "version": "6.0.1", "resolved": "https://registry.npmjs.org/parse5/-/parse5-6.0.1.tgz", @@ -7406,26 +7303,6 @@ "node": ">=6" } }, - "node_modules/puppeteer": { - "version": "22.15.0", - "resolved": "https://registry.npmjs.org/puppeteer/-/puppeteer-22.15.0.tgz", - "integrity": "sha512-XjCY1SiSEi1T7iSYuxS82ft85kwDJUS7wj1Z0eGVXKdtr5g4xnVcbjwxhq5xBnpK/E7x1VZZoJDxpjAOasHT4Q==", - "dev": true, - "hasInstallScript": true, - "license": "Apache-2.0", - "dependencies": { - "@puppeteer/browsers": "2.3.0", - "cosmiconfig": "^9.0.0", - "devtools-protocol": "0.0.1312386", - "puppeteer-core": "22.15.0" - }, - "bin": { - "puppeteer": "lib/esm/puppeteer/node/cli.js" - }, - "engines": { - "node": ">=18" - } - }, "node_modules/puppeteer-core": { "version": "22.15.0", "resolved": "https://registry.npmjs.org/puppeteer-core/-/puppeteer-core-22.15.0.tgz", diff --git a/package.json b/package.json index e5630238..dd10c052 100755 --- a/package.json +++ b/package.json @@ -278,7 +278,6 @@ "@web/dev-server": "^0.4.6", "@web/test-runner": "^0.18.3", "@web/test-runner-playwright": "^0.11.0", - "@web/test-runner-puppeteer": "^0.16.0", "clean-css": "^5.1.2", "codemirror": "^5.65.9", "codemirror-grammar-mode": "^0.1.10", diff --git a/web-test-runner.config.js b/web-test-runner.config.js index 64c1a37c..a3e5e241 100644 --- a/web-test-runner.config.js +++ b/web-test-runner.config.js @@ -5,7 +5,6 @@ */ import {playwrightLauncher} from '@web/test-runner-playwright'; -// import {puppeteerLauncher} from '@web/test-runner-puppeteer'; import {fakeCdnPlugin} from './test/fake-cdn-plugin.js'; import {startDevServer} from '@web/dev-server'; @@ -39,14 +38,6 @@ export default { playwrightLauncher({product: 'chromium'}), playwrightLauncher({product: 'webkit'}), playwrightLauncher({product: 'firefox'}), - // Playwright Firefox does not currently work with service workers, see - // https://github.com/microsoft/playwright/issues/7288. - // - // Also note we can't use Puppeteer for both Chromium and Firefox, because - // only one or the other can be installed at once (see our "postinstall" NPM - // script). See - // https://modern-web.dev/docs/test-runner/browser-launchers/puppeteer/. - // puppeteerLauncher({launchOptions: {product: 'firefox'}, concurrency: 1}), ], concurrentBrowsers: Number(process.env.CONCURRENT_BROWSERS) || 2, // default 2 browserStartTimeout: 30000, // default 30000