Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reopen the file stream if the read error is ESTALE. #514

Merged
merged 1 commit into from
May 7, 2021
Merged

Reopen the file stream if the read error is ESTALE. #514

merged 1 commit into from
May 7, 2021

Conversation

jaqx0r
Copy link
Contributor

@jaqx0r jaqx0r commented May 7, 2021

Issue #505

github-actions[bot]
github-actions bot previously approved these changes May 7, 2021
View reviewed changes
@jaqx0r jaqx0r linked an issue May 7, 2021 that may be closed by this pull request
NFS: Stale file handle - after log cycling occurs. #505
Open
@jaqx0r jaqx0r enabled auto-merge May 7, 2021 02:21
@jaqx0r jaqx0r force-pushed the stale-file-handle branch from 468537c to 93366ad Compare May 7, 2021 02:24
github-actions[bot]
github-actions bot previously approved these changes May 7, 2021
View reviewed changes
@jaqx0r jaqx0r force-pushed the stale-file-handle branch from 93366ad to 23ff9be Compare May 7, 2021 02:25
@jaqx0r jaqx0r merged commit 922ce3c into main May 7, 2021
@jaqx0r jaqx0r deleted the stale-file-handle branch May 7, 2021 02:31
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2021

Unit Test Results

       1 files  ±0       25 suites  ±0   7m 17s ⏱️ - 2m 0s
   547 tests ±0     543 ✔️ ±0    4 💤 ±0  0 ❌ ±0 
1 617 runs  ±0  1 605 ✔️ ±0  12 💤 ±0  0 ❌ ±0 

Results for commit 922ce3c. ± Comparison against base commit 12162ff.

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2021 •
edited
Loading

Benchmark Result

Benchmark diff with base 
name                                                                          old time/op    new time/op    delta
pkg:github.com/google/mtail/internal/metrics goos:linux goarch:amd64
Store/Add-1                                                                      559ns ± 6%     623ns ±13%  +11.51%  (p=0.016 n=5+5)
Store/Add-1-2                                                                    569ns ± 4%     608ns ± 3%   +6.78%  (p=0.008 n=5+5)
Store/Add-1-4                                                                    584ns ± 4%     607ns ± 4%   +4.05%  (p=0.032 n=5+5)
Store/Add-2                                                                     1.16µs ± 2%    1.26µs ± 3%   +8.65%  (p=0.008 n=5+5)
Store/Add-2-2                                                                   1.16µs ± 3%    1.23µs ± 1%   +6.40%  (p=0.008 n=5+5)
Store/Add-2-4                                                                   1.18µs ± 3%    1.24µs ± 5%   +4.85%  (p=0.008 n=5+5)
Store/Add-4                                                                     2.37µs ± 1%    2.56µs ± 1%   +7.95%  (p=0.008 n=5+5)
Store/Add-4-2                                                                   2.43µs ± 3%    2.51µs ± 2%     ~     (p=0.056 n=5+5)
Store/Add-4-4                                                                   2.39µs ± 2%    2.56µs ± 1%   +7.00%  (p=0.008 n=5+5)
Store/Add-8                                                                     4.96µs ± 2%    5.43µs ± 1%   +9.46%  (p=0.008 n=5+5)
Store/Add-8-2                                                                   5.13µs ± 7%    5.28µs ± 2%     ~     (p=0.151 n=5+5)
Store/Add-8-4                                                                   5.03µs ± 1%    5.26µs ± 1%   +4.54%  (p=0.008 n=5+5)
Store/Add-16                                                                    11.3µs ±13%    12.6µs ±11%     ~     (p=0.095 n=5+5)
Store/Add-16-2                                                                  11.2µs ± 5%    11.8µs ± 4%   +5.87%  (p=0.032 n=5+5)
Store/Add-16-4                                                                  11.4µs ± 3%    11.9µs ± 4%   +4.18%  (p=0.032 n=5+5)
Store/Add-32                                                                    22.8µs ±13%    24.6µs ± 6%     ~     (p=0.095 n=5+5)
Store/Add-32-2                                                                  23.0µs ± 1%    24.6µs ± 6%   +6.83%  (p=0.016 n=4+5)
Store/Add-32-4                                                                  23.2µs ± 2%    24.3µs ± 1%   +4.48%  (p=0.029 n=4+4)
Store/Add-64                                                                    46.7µs ± 9%    51.7µs ± 8%  +10.68%  (p=0.032 n=5+5)
Store/Add-64-2                                                                  47.5µs ± 3%    49.8µs ± 3%     ~     (p=0.056 n=5+5)
Store/Add-64-4                                                                  49.9µs ± 6%    51.3µs ± 7%     ~     (p=0.421 n=5+5)
Store/Add-128                                                                   94.6µs ± 3%   104.6µs ± 4%  +10.61%  (p=0.008 n=5+5)
Store/Add-128-2                                                                 96.4µs ± 4%   100.9µs ± 4%   +4.74%  (p=0.016 n=5+5)
Store/Add-128-4                                                                  103µs ± 8%     103µs ± 2%     ~     (p=1.000 n=5+5)
Store/Add-256                                                                    208µs ± 5%     225µs ± 4%   +8.32%  (p=0.008 n=5+5)
Store/Add-256-2                                                                  197µs ± 2%     210µs ± 2%   +6.41%  (p=0.008 n=5+5)
Store/Add-256-4                                                                  203µs ± 3%     212µs ± 3%   +4.68%  (p=0.016 n=5+5)
Store/Add-512                                                                    412µs ± 2%     462µs ± 4%  +12.09%  (p=0.008 n=5+5)
Store/Add-512-2                                                                  411µs ± 3%     438µs ± 3%   +6.78%  (p=0.008 n=5+5)
Store/Add-512-4                                                                  414µs ± 4%     438µs ± 4%   +5.69%  (p=0.016 n=5+5)
Store/Add-1024                                                                   876µs ± 2%     951µs ± 2%   +8.63%  (p=0.008 n=5+5)
Store/Add-1024-2                                                                 822µs ± 2%     887µs ± 2%   +7.94%  (p=0.008 n=5+5)
Store/Add-1024-4                                                                 857µs ± 3%     897µs ± 2%   +4.65%  (p=0.008 n=5+5)
Store/AddParallel-1                                                              567ns ± 2%     618ns ± 3%   +8.91%  (p=0.008 n=5+5)
Store/AddParallel-1-2                                                            615ns ± 3%     662ns ± 3%   +7.57%  (p=0.008 n=5+5)
Store/AddParallel-1-4                                                            622ns ± 4%     650ns ± 3%   +4.45%  (p=0.032 n=5+5)
Store/AddParallel-2                                                             1.16µs ± 2%    1.27µs ± 3%   +8.78%  (p=0.008 n=5+5)
Store/AddParallel-2-2                                                           1.21µs ± 3%    1.30µs ± 2%   +7.41%  (p=0.008 n=5+5)
Store/AddParallel-2-4                                                           1.24µs ± 3%    1.34µs ± 3%   +7.45%  (p=0.008 n=5+5)
Store/AddParallel-4                                                             2.40µs ± 1%    2.59µs ± 3%   +7.69%  (p=0.008 n=5+5)
Store/AddParallel-4-2                                                           2.60µs ± 2%    2.67µs ± 1%   +2.44%  (p=0.032 n=5+5)
Store/AddParallel-4-4                                                           2.62µs ± 3%    2.71µs ± 5%     ~     (p=0.056 n=5+5)
Store/AddParallel-8                                                             5.32µs ± 4%    5.42µs ± 1%     ~     (p=0.246 n=5+5)
Store/AddParallel-8-2                                                           5.32µs ± 3%    5.53µs ± 2%   +3.77%  (p=0.016 n=5+5)
Store/AddParallel-8-4                                                           5.33µs ± 1%    5.62µs ± 2%   +5.45%  (p=0.008 n=5+5)
Store/AddParallel-16                                                            11.1µs ± 2%    12.7µs ± 9%  +14.53%  (p=0.008 n=5+5)
Store/AddParallel-16-2                                                          11.8µs ± 3%    13.0µs ±12%  +10.05%  (p=0.008 n=5+5)
Store/AddParallel-16-4                                                          11.8µs ± 3%    12.7µs ± 3%   +7.85%  (p=0.008 n=5+5)
Store/AddParallel-32                                                            22.9µs ± 8%    25.0µs ± 6%     ~     (p=0.056 n=5+5)
Store/AddParallel-32-2                                                          23.8µs ± 5%    25.5µs ± 4%   +7.44%  (p=0.008 n=5+5)
Store/AddParallel-32-4                                                          25.3µs ± 7%    25.8µs ± 3%     ~     (p=1.000 n=5+5)
Store/AddParallel-64                                                            48.7µs ±11%    51.9µs ± 4%     ~     (p=0.151 n=5+5)
Store/AddParallel-64-2                                                          48.1µs ± 4%    52.5µs ± 9%   +9.16%  (p=0.008 n=5+5)
Store/AddParallel-64-4                                                          50.4µs ± 4%    51.5µs ± 3%     ~     (p=0.310 n=5+5)
Store/AddParallel-128                                                           96.0µs ± 3%   105.0µs ± 4%   +9.45%  (p=0.008 n=5+5)
Store/AddParallel-128-2                                                          103µs ± 3%     106µs ± 5%     ~     (p=0.151 n=5+5)
Store/AddParallel-128-4                                                          104µs ± 4%     112µs ± 5%   +7.68%  (p=0.016 n=5+5)
Store/AddParallel-256                                                            202µs ± 0%     227µs ± 5%  +12.08%  (p=0.016 n=4+5)
Store/AddParallel-256-2                                                          218µs ± 5%     229µs ± 6%   +4.99%  (p=0.032 n=5+5)
Store/AddParallel-256-4                                                          218µs ± 4%     234µs ± 5%   +7.51%  (p=0.016 n=5+5)
Store/AddParallel-512                                                            417µs ± 2%     472µs ± 2%  +13.41%  (p=0.008 n=5+5)
Store/AddParallel-512-2                                                          435µs ± 4%     469µs ± 2%   +7.78%  (p=0.008 n=5+5)
Store/AddParallel-512-4                                                          456µs ± 4%     484µs ± 2%   +6.16%  (p=0.008 n=5+5)
Store/AddParallel-1024                                                           858µs ± 4%     956µs ± 2%  +11.37%  (p=0.008 n=5+5)
Store/AddParallel-1024-2                                                         882µs ± 2%     947µs ± 2%   +7.33%  (p=0.008 n=5+5)
Store/AddParallel-1024-4                                                         879µs ± 3%     950µs ± 2%   +8.11%  (p=0.008 n=5+5)
Store/AddWithGc-1                                                               2.85µs ±36%    2.58µs ± 2%     ~     (p=0.841 n=5+5)
Store/AddWithGc-1-2                                                             2.64µs ± 2%    2.59µs ± 1%     ~     (p=0.095 n=5+5)
Store/AddWithGc-1-4                                                             2.64µs ± 4%    2.61µs ± 1%     ~     (p=0.286 n=5+4)
Store/AddWithGc-2                                                               3.29µs ± 5%    3.27µs ± 2%     ~     (p=1.000 n=5+5)
Store/AddWithGc-2-2                                                             3.26µs ± 3%    3.46µs ±13%     ~     (p=0.310 n=5+5)
Store/AddWithGc-2-4                                                             3.37µs ± 5%    3.24µs ± 1%     ~     (p=0.135 n=5+5)
Store/AddWithGc-4                                                               4.47µs ± 3%    4.67µs ± 1%   +4.61%  (p=0.016 n=5+4)
Store/AddWithGc-4-2                                                             4.61µs ± 2%    4.56µs ± 1%     ~     (p=0.310 n=5+5)
Store/AddWithGc-4-4                                                             4.59µs ± 2%    4.67µs ± 2%     ~     (p=0.095 n=5+5)
Store/AddWithGc-8                                                               7.49µs ± 4%    7.66µs ± 1%     ~     (p=0.413 n=5+4)
Store/AddWithGc-8-2                                                             7.35µs ± 2%    7.51µs ± 3%     ~     (p=0.111 n=4+5)
Store/AddWithGc-8-4                                                             7.57µs ± 3%    7.55µs ± 2%     ~     (p=0.905 n=5+4)
Store/AddWithGc-16                                                              13.9µs ± 8%    14.8µs ± 2%     ~     (p=0.151 n=5+5)
Store/AddWithGc-16-2                                                            13.7µs ± 2%    14.7µs ± 9%   +7.22%  (p=0.008 n=5+5)
Store/AddWithGc-16-4                                                            14.1µs ± 2%    14.7µs ± 2%     ~     (p=0.063 n=4+5)
Store/AddWithGc-32                                                              25.8µs ± 3%    28.0µs ± 1%   +8.72%  (p=0.008 n=5+5)
Store/AddWithGc-32-2                                                            25.9µs ± 5%    27.5µs ± 7%     ~     (p=0.056 n=5+5)
Store/AddWithGc-32-4                                                            26.4µs ± 3%    27.5µs ± 3%   +4.12%  (p=0.032 n=5+5)
Store/AddWithGc-64                                                              57.3µs ±21%    57.9µs ± 3%     ~     (p=0.151 n=5+5)
Store/AddWithGc-64-2                                                            50.8µs ± 6%    54.6µs ± 7%     ~     (p=0.056 n=5+5)
Store/AddWithGc-64-4                                                            52.9µs ± 8%    56.3µs ± 5%     ~     (p=0.095 n=5+5)
Store/AddWithGc-128                                                              102µs ± 4%     115µs ± 4%  +12.52%  (p=0.008 n=5+5)
Store/AddWithGc-128-2                                                            109µs ± 5%     106µs ± 1%     ~     (p=0.151 n=5+5)
Store/AddWithGc-128-4                                                            110µs ± 5%     110µs ± 3%     ~     (p=0.841 n=5+5)
Store/AddWithGc-256                                                              234µs ± 7%     239µs ± 4%     ~     (p=0.841 n=5+5)
Store/AddWithGc-256-2                                                            221µs ± 8%     224µs ± 7%     ~     (p=0.841 n=5+5)
Store/AddWithGc-256-4                                                            220µs ± 1%     226µs ± 3%   +2.79%  (p=0.016 n=5+5)
Store/AddWithGc-512                                                              443µs ± 2%     498µs ± 3%  +12.48%  (p=0.008 n=5+5)
Store/AddWithGc-512-2                                                            430µs ± 4%     458µs ± 1%   +6.51%  (p=0.008 n=5+5)
Store/AddWithGc-512-4                                                            438µs ± 5%     469µs ± 3%   +6.90%  (p=0.008 n=5+5)
Store/AddWithGc-1024                                                             894µs ± 3%    1000µs ± 3%  +11.88%  (p=0.008 n=5+5)
Store/AddWithGc-1024-2                                                           862µs ± 2%     916µs ± 1%   +6.36%  (p=0.008 n=5+5)
Store/AddWithGc-1024-4                                                           885µs ± 2%     930µs ± 1%   +5.12%  (p=0.008 n=5+5)
Store/AddWithGcParallel-1                                                        572ns ± 3%     641ns ± 2%  +11.96%  (p=0.008 n=5+5)
Store/AddWithGcParallel-1-2                                                      635ns ± 1%     633ns ± 3%     ~     (p=0.690 n=5+5)
Store/AddWithGcParallel-1-4                                                      627ns ± 3%     662ns ± 7%   +5.55%  (p=0.032 n=5+5)
Store/AddWithGcParallel-2                                                       1.19µs ± 2%    1.26µs ± 1%   +6.22%  (p=0.008 n=5+5)
Store/AddWithGcParallel-2-2                                                     1.28µs ± 4%    1.30µs ± 4%     ~     (p=0.421 n=5+5)
Store/AddWithGcParallel-2-4                                                     1.28µs ± 3%    1.30µs ± 3%     ~     (p=0.151 n=5+5)
Store/AddWithGcParallel-4                                                       2.44µs ± 2%    2.59µs ± 1%   +6.15%  (p=0.008 n=5+5)
Store/AddWithGcParallel-4-2                                                     2.64µs ± 2%    2.68µs ± 3%     ~     (p=0.421 n=5+5)
Store/AddWithGcParallel-4-4                                                     2.71µs ± 2%    2.70µs ± 2%     ~     (p=0.651 n=5+5)
Store/AddWithGcParallel-8                                                       5.04µs ± 2%    5.57µs ± 3%  +10.37%  (p=0.008 n=5+5)
Store/AddWithGcParallel-8-2                                                     5.34µs ± 2%    5.60µs ± 2%   +4.94%  (p=0.008 n=5+5)
Store/AddWithGcParallel-8-4                                                     5.49µs ± 6%    5.69µs ± 2%     ~     (p=0.095 n=5+5)
Store/AddWithGcParallel-16                                                      11.3µs ± 1%    12.3µs ± 2%   +8.62%  (p=0.008 n=5+5)
Store/AddWithGcParallel-16-2                                                    12.0µs ± 5%    12.5µs ± 2%     ~     (p=0.151 n=5+5)
Store/AddWithGcParallel-16-4                                                    12.3µs ± 4%    12.4µs ± 3%     ~     (p=0.548 n=5+5)
Store/AddWithGcParallel-32                                                      22.6µs ± 1%    24.5µs ± 2%   +8.79%  (p=0.016 n=4+5)
Store/AddWithGcParallel-32-2                                                    24.5µs ± 8%    26.4µs ±13%     ~     (p=0.095 n=5+5)
Store/AddWithGcParallel-32-4                                                    25.0µs ±10%    25.6µs ± 5%     ~     (p=0.151 n=5+5)
Store/AddWithGcParallel-64                                                      47.7µs ± 4%    51.4µs ± 5%   +7.81%  (p=0.008 n=5+5)
Store/AddWithGcParallel-64-2                                                    50.4µs ± 5%    52.7µs ± 4%     ~     (p=0.056 n=5+5)
Store/AddWithGcParallel-64-4                                                    49.4µs ± 6%    53.5µs ± 3%   +8.24%  (p=0.016 n=5+5)
Store/AddWithGcParallel-128                                                     93.4µs ± 1%   108.5µs ± 3%  +16.17%  (p=0.008 n=5+5)
Store/AddWithGcParallel-128-2                                                    101µs ± 5%     108µs ± 3%   +7.56%  (p=0.008 n=5+5)
Store/AddWithGcParallel-128-4                                                    106µs ± 3%     112µs ± 3%   +5.74%  (p=0.032 n=5+5)
Store/AddWithGcParallel-256                                                      201µs ± 2%     221µs ± 2%  +10.04%  (p=0.008 n=5+5)
Store/AddWithGcParallel-256-2                                                    210µs ± 5%     228µs ± 2%   +8.47%  (p=0.008 n=5+5)
Store/AddWithGcParallel-256-4                                                    215µs ± 3%     232µs ± 2%   +8.14%  (p=0.008 n=5+5)
Store/AddWithGcParallel-512                                                      413µs ± 3%     471µs ± 2%  +14.08%  (p=0.008 n=5+5)
Store/AddWithGcParallel-512-2                                                    432µs ± 4%     470µs ± 2%   +8.65%  (p=0.008 n=5+5)
Store/AddWithGcParallel-512-4                                                    461µs ± 3%     484µs ± 6%   +4.89%  (p=0.008 n=5+5)
Store/AddWithGcParallel-1024                                                     858µs ± 2%     973µs ± 2%  +13.39%  (p=0.008 n=5+5)
Store/AddWithGcParallel-1024-2                                                   907µs ± 2%     929µs ± 1%   +2.40%  (p=0.008 n=5+5)
Store/AddWithGcParallel-1024-4                                                   890µs ± 2%     943µs ± 2%   +6.03%  (p=0.008 n=5+5)
Store/Iterate-1                                                                 70.5ns ± 0%    75.4ns ± 1%   +7.03%  (p=0.016 n=4+5)
Store/Iterate-1-2                                                               72.4ns ± 7%    75.0ns ± 2%     ~     (p=0.151 n=5+5)
Store/Iterate-1-4                                                               70.9ns ± 0%    75.6ns ± 2%   +6.57%  (p=0.016 n=4+5)
Store/Iterate-2                                                                 85.5ns ± 5%    89.6ns ± 0%     ~     (p=0.056 n=5+5)
Store/Iterate-2-2                                                               85.6ns ± 6%    90.1ns ± 4%     ~     (p=0.095 n=5+5)
Store/Iterate-2-4                                                               90.4ns ± 7%    90.2ns ± 1%     ~     (p=0.690 n=5+5)
Store/Iterate-4                                                                  113ns ± 0%     122ns ± 1%   +8.34%  (p=0.008 n=5+5)
Store/Iterate-4-2                                                                113ns ± 0%     122ns ± 2%   +7.64%  (p=0.016 n=4+5)
Store/Iterate-4-4                                                                119ns ± 5%     122ns ± 1%     ~     (p=0.794 n=5+5)
Store/Iterate-8                                                                  156ns ± 0%     166ns ± 1%   +6.47%  (p=0.016 n=4+5)
Store/Iterate-8-2                                                                161ns ± 9%     167ns ± 2%     ~     (p=0.151 n=5+5)
Store/Iterate-8-4                                                                161ns ± 8%     168ns ± 2%     ~     (p=0.310 n=5+5)
Store/Iterate-16                                                                 339ns ± 4%     367ns ± 2%   +8.23%  (p=0.008 n=5+5)
Store/Iterate-16-2                                                               361ns ± 9%     370ns ± 4%     ~     (p=0.690 n=5+5)
Store/Iterate-16-4                                                               352ns ± 3%     373ns ± 2%   +5.97%  (p=0.008 n=5+5)
Store/Iterate-32                                                                 661ns ± 5%     709ns ± 2%   +7.28%  (p=0.008 n=5+5)
Store/Iterate-32-2                                                               679ns ± 5%     700ns ± 4%     ~     (p=0.151 n=5+5)
Store/Iterate-32-4                                                               680ns ± 6%     708ns ± 4%     ~     (p=0.222 n=5+5)
Store/Iterate-64                                                                1.36µs ± 2%    1.41µs ± 4%     ~     (p=0.095 n=5+5)
Store/Iterate-64-2                                                              1.33µs ± 2%    1.40µs ± 2%   +5.38%  (p=0.008 n=5+5)
Store/Iterate-64-4                                                              1.36µs ± 5%    1.40µs ± 3%     ~     (p=0.222 n=5+5)
Store/Iterate-128                                                               2.73µs ± 6%    2.90µs ± 1%     ~     (p=0.056 n=5+5)
Store/Iterate-128-2                                                             2.73µs ± 6%    2.88µs ± 2%     ~     (p=0.056 n=5+5)
Store/Iterate-128-4                                                             2.81µs ± 8%    2.90µs ± 4%     ~     (p=0.548 n=5+5)
Store/Iterate-256                                                               5.43µs ± 1%    5.89µs ± 3%   +8.35%  (p=0.008 n=5+5)
Store/Iterate-256-2                                                             5.63µs ± 8%    5.79µs ± 2%     ~     (p=0.222 n=5+5)
Store/Iterate-256-4                                                             5.57µs ± 7%    5.79µs ± 4%     ~     (p=0.151 n=5+5)
Store/Iterate-512                                                               11.7µs ± 7%    12.0µs ± 1%     ~     (p=0.548 n=5+5)
Store/Iterate-512-2                                                             10.8µs ± 1%    11.8µs ± 3%   +9.31%  (p=0.008 n=5+5)
Store/Iterate-512-4                                                             10.9µs ± 7%    11.8µs ± 2%   +8.36%  (p=0.016 n=5+5)
Store/Iterate-1024                                                              22.0µs ± 6%    24.1µs ± 2%   +9.29%  (p=0.008 n=5+5)
Store/Iterate-1024-2                                                            21.5µs ± 1%    24.0µs ± 1%  +11.85%  (p=0.016 n=4+5)
Store/Iterate-1024-4                                                            21.4µs ± 1%    23.9µs ± 1%  +11.42%  (p=0.016 n=4+5)
Store/IterateParallel-1                                                         72.4ns ± 1%    76.5ns ± 1%   +5.77%  (p=0.008 n=5+5)
Store/IterateParallel-1-2                                                        123ns ± 6%     110ns ± 3%  -10.56%  (p=0.008 n=5+5)
Store/IterateParallel-1-4                                                        127ns ±10%     113ns ± 2%  -11.04%  (p=0.016 n=5+5)
Store/IterateParallel-2                                                         89.9ns ± 0%    92.2ns ± 2%   +2.49%  (p=0.008 n=5+5)
Store/IterateParallel-2-2                                                        147ns ± 4%     109ns ±28%  -25.92%  (p=0.008 n=5+5)
Store/IterateParallel-2-4                                                        147ns ± 2%     109ns ±30%  -25.72%  (p=0.008 n=5+5)
Store/IterateParallel-4                                                          115ns ± 1%     122ns ± 2%   +6.62%  (p=0.008 n=5+5)
Store/IterateParallel-4-2                                                        108ns ± 3%     134ns ± 5%  +24.35%  (p=0.008 n=5+5)
Store/IterateParallel-4-4                                                        109ns ± 5%     128ns ± 4%  +17.92%  (p=0.008 n=5+5)
Store/IterateParallel-8                                                          158ns ± 0%     168ns ± 1%   +6.55%  (p=0.008 n=5+5)
Store/IterateParallel-8-2                                                        148ns ±27%     153ns ± 4%     ~     (p=0.690 n=5+5)
Store/IterateParallel-8-4                                                        151ns ±27%     158ns ±12%     ~     (p=0.690 n=5+5)
Store/IterateParallel-16                                                         341ns ± 3%     368ns ± 2%   +7.93%  (p=0.008 n=5+5)
Store/IterateParallel-16-2                                                       234ns ±14%     212ns ± 3%     ~     (p=0.151 n=5+5)
Store/IterateParallel-16-4                                                       244ns ±16%     210ns ± 5%     ~     (p=0.222 n=5+5)
Store/IterateParallel-32                                                         665ns ± 4%     701ns ± 3%   +5.46%  (p=0.016 n=5+5)
Store/IterateParallel-32-2                                                       359ns ± 4%     385ns ± 5%   +7.50%  (p=0.008 n=5+5)
Store/IterateParallel-32-4                                                       360ns ± 6%     394ns ± 6%   +9.53%  (p=0.032 n=5+5)
Store/IterateParallel-64                                                        1.32µs ± 2%    1.40µs ± 5%   +6.02%  (p=0.016 n=5+5)
Store/IterateParallel-64-2                                                       699ns ± 5%     730ns ± 3%   +4.39%  (p=0.032 n=5+5)
Store/IterateParallel-64-4                                                       692ns ± 3%     736ns ± 3%   +6.33%  (p=0.008 n=5+5)
Store/IterateParallel-128                                                       2.74µs ± 2%    2.84µs ± 2%   +3.70%  (p=0.016 n=5+5)
Store/IterateParallel-128-2                                                     1.39µs ± 5%    1.43µs ± 1%     ~     (p=0.595 n=5+5)
Store/IterateParallel-128-4                                                     1.43µs ± 4%    1.44µs ± 2%     ~     (p=0.548 n=5+5)
Store/IterateParallel-256                                                       5.88µs ± 3%    5.82µs ± 5%     ~     (p=0.421 n=5+5)
Store/IterateParallel-256-2                                                     2.85µs ± 1%    2.90µs ± 2%     ~     (p=0.151 n=5+5)
Store/IterateParallel-256-4                                                     2.74µs ± 2%    2.90µs ± 2%   +5.86%  (p=0.008 n=5+5)
Store/IterateParallel-512                                                       10.8µs ± 1%    11.7µs ± 2%   +8.20%  (p=0.008 n=5+5)
Store/IterateParallel-512-2                                                     5.48µs ± 1%    5.83µs ± 1%   +6.33%  (p=0.008 n=5+5)
Store/IterateParallel-512-4                                                     5.51µs ± 2%    5.84µs ± 1%   +5.90%  (p=0.016 n=5+4)
Store/IterateParallel-1024                                                      21.5µs ± 2%    23.2µs ± 1%   +8.21%  (p=0.008 n=5+5)
Store/IterateParallel-1024-2                                                    11.1µs ± 2%    11.5µs ± 1%   +3.01%  (p=0.008 n=5+5)
Store/IterateParallel-1024-4                                                    11.2µs ± 3%    11.6µs ± 1%   +3.23%  (p=0.016 n=5+5)
Store/IterateWithGc-1                                                           1.95µs ± 2%    1.98µs ± 1%     ~     (p=0.222 n=5+5)
Store/IterateWithGc-1-2                                                         1.99µs ± 3%    1.98µs ± 5%     ~     (p=0.413 n=5+4)
Store/IterateWithGc-1-4                                                         1.98µs ± 1%    1.96µs ± 1%   -1.16%  (p=0.016 n=5+5)
Store/IterateWithGc-2                                                           1.96µs ± 0%    2.03µs ± 1%   +3.47%  (p=0.008 n=5+5)
Store/IterateWithGc-2-2                                                         2.08µs ±15%    2.01µs ± 2%     ~     (p=0.889 n=5+5)
Store/IterateWithGc-2-4                                                         2.04µs ± 2%    2.37µs ±33%     ~     (p=0.310 n=5+5)
Store/IterateWithGc-4                                                           2.21µs ± 4%    2.10µs ± 1%   -4.70%  (p=0.016 n=5+4)
Store/IterateWithGc-4-2                                                         2.09µs ± 3%    2.08µs ± 1%     ~     (p=0.421 n=5+5)
Store/IterateWithGc-4-4                                                         2.25µs ±24%    2.11µs ± 1%     ~     (p=0.889 n=5+5)
Store/IterateWithGc-8                                                           2.16µs ± 3%    2.58µs ±40%  +19.22%  (p=0.016 n=5+5)
Store/IterateWithGc-8-2                                                         2.21µs ± 5%    2.22µs ± 2%     ~     (p=0.556 n=5+4)
Store/IterateWithGc-8-4                                                         2.24µs ± 2%    2.24µs ± 2%     ~     (p=1.000 n=5+5)
Store/IterateWithGc-16                                                          2.61µs ± 1%    2.72µs ± 2%   +4.44%  (p=0.016 n=4+5)
Store/IterateWithGc-16-2                                                        2.91µs ±28%    2.67µs ± 1%     ~     (p=0.310 n=5+5)
Store/IterateWithGc-16-4                                                        2.72µs ± 1%    3.13µs ±22%     ~     (p=0.524 n=5+5)
Store/IterateWithGc-32                                                          3.46µs ± 4%    3.50µs ± 2%     ~     (p=0.310 n=5+5)
Store/IterateWithGc-32-2                                                        3.37µs ± 2%    3.46µs ± 3%   +2.78%  (p=0.032 n=5+5)
Store/IterateWithGc-32-4                                                        3.40µs ± 4%    3.51µs ± 2%     ~     (p=0.095 n=5+5)
Store/IterateWithGc-64                                                          5.04µs ± 4%    5.29µs ± 2%   +5.00%  (p=0.032 n=4+5)
Store/IterateWithGc-64-2                                                        4.91µs ± 2%    5.02µs ± 2%     ~     (p=0.190 n=5+4)
Store/IterateWithGc-64-4                                                        5.10µs ± 2%    5.24µs ± 2%     ~     (p=0.151 n=5+5)
Store/IterateWithGc-128                                                         8.75µs ± 8%    8.66µs ± 2%     ~     (p=1.000 n=5+5)
Store/IterateWithGc-128-2                                                       8.12µs ± 5%    8.29µs ± 4%     ~     (p=0.556 n=4+5)
Store/IterateWithGc-128-4                                                       8.13µs ± 4%    8.37µs ± 6%     ~     (p=0.413 n=5+4)
Store/IterateWithGc-256                                                         15.6µs ± 4%    15.3µs ± 4%     ~     (p=0.421 n=5+5)
Store/IterateWithGc-256-2                                                       14.4µs ± 4%    14.9µs ± 2%   +3.31%  (p=0.032 n=5+5)
Store/IterateWithGc-256-4                                                       16.4µs ±39%    14.6µs ± 2%     ~     (p=0.548 n=5+5)
Store/IterateWithGc-512                                                         27.7µs ±10%    28.1µs ± 1%     ~     (p=0.730 n=5+4)
Store/IterateWithGc-512-2                                                       26.8µs ± 4%    26.8µs ± 2%     ~     (p=0.841 n=5+5)
Store/IterateWithGc-512-4                                                       27.1µs ± 4%    27.2µs ± 4%     ~     (p=1.000 n=5+5)
Store/IterateWithGc-1024                                                        54.0µs ±24%    54.3µs ± 1%     ~     (p=0.548 n=5+5)
Store/IterateWithGc-1024-2                                                      49.6µs ± 5%    54.7µs ±10%  +10.40%  (p=0.008 n=5+5)
Store/IterateWithGc-1024-4                                                      51.1µs ± 5%    53.4µs ± 1%   +4.39%  (p=0.032 n=5+5)
Store/IterateWithGcParallel-1                                                   78.1ns ± 3%    76.1ns ± 1%   -2.54%  (p=0.032 n=5+5)
Store/IterateWithGcParallel-1-2                                                  117ns ±17%     111ns ± 2%     ~     (p=0.151 n=5+5)
Store/IterateWithGcParallel-1-4                                                  126ns ± 5%     112ns ± 5%  -11.32%  (p=0.008 n=5+5)
Store/IterateWithGcParallel-2                                                   84.2ns ± 0%    92.7ns ± 3%  +10.15%  (p=0.008 n=5+5)
Store/IterateWithGcParallel-2-2                                                  129ns ±33%     122ns ± 6%     ~     (p=0.151 n=5+5)
Store/IterateWithGcParallel-2-4                                                  140ns ± 2%     123ns ± 7%  -11.95%  (p=0.008 n=5+5)
Store/IterateWithGcParallel-4                                                    114ns ± 0%     121ns ±11%     ~     (p=0.127 n=5+5)
Store/IterateWithGcParallel-4-2                                                  138ns ±15%     140ns ± 7%     ~     (p=0.690 n=5+5)
Store/IterateWithGcParallel-4-4                                                  131ns ±16%     126ns ±32%     ~     (p=0.952 n=5+5)
Store/IterateWithGcParallel-8                                                    158ns ± 0%     171ns ± 3%   +8.34%  (p=0.008 n=5+5)
Store/IterateWithGcParallel-8-2                                                  144ns ±21%     131ns ± 6%     ~     (p=1.000 n=5+5)
Store/IterateWithGcParallel-8-4                                                  159ns ±18%     131ns ± 8%     ~     (p=0.222 n=5+5)
Store/IterateWithGcParallel-16                                                   352ns ± 3%     380ns ± 3%   +7.83%  (p=0.008 n=5+5)
Store/IterateWithGcParallel-16-2                                                 243ns ±15%     228ns ± 8%     ~     (p=0.690 n=5+5)
Store/IterateWithGcParallel-16-4                                                 258ns ±18%     231ns ± 8%     ~     (p=0.310 n=5+5)
Store/IterateWithGcParallel-32                                                   656ns ± 3%     708ns ± 3%   +7.97%  (p=0.008 n=5+5)
Store/IterateWithGcParallel-32-2                                                 358ns ± 2%     388ns ± 7%   +8.57%  (p=0.008 n=5+5)
Store/IterateWithGcParallel-32-4                                                 361ns ± 4%     389ns ± 9%     ~     (p=0.151 n=5+5)
Store/IterateWithGcParallel-64                                                  1.31µs ± 5%    1.44µs ± 2%   +9.49%  (p=0.008 n=5+5)
Store/IterateWithGcParallel-64-2                                                 728ns ± 7%     736ns ± 4%     ~     (p=0.952 n=5+5)
Store/IterateWithGcParallel-64-4                                                 751ns ± 8%     729ns ± 2%     ~     (p=0.690 n=5+5)
Store/IterateWithGcParallel-128                                                 2.71µs ± 2%    2.88µs ± 4%   +6.30%  (p=0.008 n=5+5)
Store/IterateWithGcParallel-128-2                                               1.42µs ± 2%    1.47µs ± 4%   +3.68%  (p=0.032 n=5+5)
Store/IterateWithGcParallel-128-4                                               1.43µs ± 4%    1.48µs ± 4%     ~     (p=0.056 n=5+5)
Store/IterateWithGcParallel-256                                                 5.42µs ± 3%    5.75µs ± 2%   +6.08%  (p=0.008 n=5+5)
Store/IterateWithGcParallel-256-2                                               2.77µs ± 3%    2.91µs ± 2%   +5.00%  (p=0.008 n=5+5)
Store/IterateWithGcParallel-256-4                                               2.81µs ± 1%    2.90µs ± 3%   +3.23%  (p=0.008 n=5+5)
Store/IterateWithGcParallel-512                                                 10.9µs ± 4%    11.6µs ± 2%   +6.82%  (p=0.008 n=5+5)
Store/IterateWithGcParallel-512-2                                               5.53µs ± 3%    5.82µs ± 3%   +5.41%  (p=0.008 n=5+5)
Store/IterateWithGcParallel-512-4                                               5.46µs ± 2%    5.83µs ± 1%   +6.65%  (p=0.008 n=5+5)
Store/IterateWithGcParallel-1024                                                21.3µs ± 2%    23.2µs ± 1%   +8.72%  (p=0.008 n=5+5)
Store/IterateWithGcParallel-1024-2                                              10.8µs ± 2%    11.5µs ± 1%   +5.78%  (p=0.008 n=5+5)
Store/IterateWithGcParallel-1024-4                                              10.8µs ± 1%    11.6µs ± 3%   +7.81%  (p=0.008 n=5+5)
Metric/GetDatum-2                                                               1.24µs ± 8%    1.35µs ± 8%   +9.47%  (p=0.032 n=5+5)
Metric/GetDatum-2-2                                                             1.09µs ±17%    1.20µs ±21%     ~     (p=0.175 n=5+5)
Metric/GetDatum-2-4                                                             1.33µs ±14%    1.37µs ±25%     ~     (p=1.000 n=5+5)
Metric/GetDatum-4                                                               2.50µs ±17%    2.78µs ±17%     ~     (p=0.421 n=5+5)
Metric/GetDatum-4-2                                                             2.21µs ±17%    2.45µs ± 7%     ~     (p=0.310 n=5+5)
Metric/GetDatum-4-4                                                             2.38µs ± 8%    2.55µs ±10%     ~     (p=0.310 n=5+5)
Metric/GetDatum-8                                                               4.81µs ± 7%    5.49µs ± 3%  +14.11%  (p=0.008 n=5+5)
Metric/GetDatum-8-2                                                             4.98µs ± 6%    4.86µs ± 7%     ~     (p=0.841 n=5+5)
Metric/GetDatum-8-4                                                             4.94µs ± 7%    5.43µs ±18%     ~     (p=0.151 n=5+5)
Metric/GetDatum-16                                                              10.5µs ± 5%    12.5µs ±10%  +19.13%  (p=0.008 n=5+5)
Metric/GetDatum-16-2                                                            9.75µs ± 7%   11.44µs ± 9%  +17.28%  (p=0.008 n=5+5)
Metric/GetDatum-16-4                                                            11.0µs ± 5%    13.3µs ±12%  +20.85%  (p=0.008 n=5+5)
Metric/GetDatum-32                                                              21.3µs ± 5%    26.5µs ± 6%  +24.72%  (p=0.008 n=5+5)
Metric/GetDatum-32-2                                                            20.2µs ± 3%    23.0µs ± 9%  +13.93%  (p=0.008 n=5+5)
Metric/GetDatum-32-4                                                            22.6µs ± 4%    26.4µs ± 7%  +16.78%  (p=0.008 n=5+5)
Metric/GetDatum-64                                                              47.1µs ± 2%    53.9µs ± 4%  +14.41%  (p=0.008 n=5+5)
Metric/GetDatum-64-2                                                            40.3µs ±10%    48.8µs ± 5%  +21.01%  (p=0.008 n=5+5)
Metric/GetDatum-64-4                                                            46.3µs ± 2%    56.2µs ± 5%  +21.30%  (p=0.008 n=5+5)
Metric/GetDatum-128                                                              101µs ± 1%     124µs ± 8%  +22.45%  (p=0.008 n=5+5)
Metric/GetDatum-128-2                                                           92.6µs ± 2%   107.2µs ± 9%  +15.74%  (p=0.008 n=5+5)
Metric/GetDatum-128-4                                                            100µs ± 5%     123µs ± 5%  +23.05%  (p=0.008 n=5+5)
Metric/GetDatum-256                                                              219µs ± 2%     247µs ± 2%  +12.83%  (p=0.008 n=5+5)
Metric/GetDatum-256-2                                                            195µs ± 4%     218µs ± 3%  +11.74%  (p=0.008 n=5+5)
Metric/GetDatum-256-4                                                            217µs ± 3%     240µs ± 3%  +10.32%  (p=0.008 n=5+5)
Metric/GetDatum-512                                                              473µs ± 2%     511µs ± 2%   +8.08%  (p=0.008 n=5+5)
Metric/GetDatum-512-2                                                            424µs ± 1%     451µs ± 2%   +6.53%  (p=0.008 n=5+5)
Metric/GetDatum-512-4                                                            458µs ± 2%     490µs ± 2%   +6.92%  (p=0.008 n=5+5)
Metric/GetDatum-1024                                                            1.00ms ± 5%    1.07ms ± 3%   +6.34%  (p=0.016 n=5+5)
Metric/GetDatum-1024-2                                                           903µs ± 1%     953µs ± 1%   +5.57%  (p=0.008 n=5+5)
Metric/GetDatum-1024-4                                                           957µs ± 3%    1036µs ± 6%   +8.23%  (p=0.008 n=5+5)
Metric/GetDatum-2048                                                            2.02ms ± 1%    2.29ms ± 8%  +13.25%  (p=0.008 n=5+5)
Metric/GetDatum-2048-2                                                          1.76ms ± 2%    1.87ms ± 3%   +6.28%  (p=0.008 n=5+5)
Metric/GetDatum-2048-4                                                          1.93ms ± 3%    2.07ms ± 4%   +7.73%  (p=0.008 n=5+5)
Metric/GetDatum-4096                                                            4.38ms ± 2%    5.25ms ± 4%  +19.89%  (p=0.008 n=5+5)
Metric/GetDatum-4096-2                                                          3.66ms ± 3%    3.94ms ± 1%   +7.46%  (p=0.008 n=5+5)
Metric/GetDatum-4096-4                                                          4.04ms ± 5%    5.39ms ±11%  +33.46%  (p=0.008 n=5+5)
Metric/GetDatum-8192                                                            10.7ms ± 3%    13.1ms ± 5%  +22.50%  (p=0.008 n=5+5)
Metric/GetDatum-8192-2                                                          8.50ms ± 2%   11.06ms ± 9%  +30.22%  (p=0.008 n=5+5)
Metric/GetDatum-8192-4                                                          8.76ms ± 4%   11.08ms ± 3%  +26.49%  (p=0.008 n=5+5)
Metric/GetDatumParallel-2                                                       1.35µs ±26%    1.38µs ±20%     ~     (p=1.000 n=5+5)
Metric/GetDatumParallel-2-2                                                     1.13µs ±14%    1.25µs ±20%     ~     (p=0.222 n=5+5)
Metric/GetDatumParallel-2-4                                                     1.29µs ±16%    1.43µs ±12%     ~     (p=0.095 n=5+5)
Metric/GetDatumParallel-4                                                       2.53µs ±15%    2.80µs ± 8%     ~     (p=0.222 n=5+5)
Metric/GetDatumParallel-4-2                                                     2.31µs ±18%    2.42µs ± 6%     ~     (p=0.841 n=5+5)
Metric/GetDatumParallel-4-4                                                     2.53µs ±16%    2.73µs ±11%     ~     (p=0.421 n=5+5)
Metric/GetDatumParallel-8                                                       4.86µs ± 6%    5.50µs ±11%  +13.26%  (p=0.032 n=5+5)
Metric/GetDatumParallel-8-2                                                     4.29µs ± 8%    5.10µs ±13%  +18.84%  (p=0.008 n=5+5)
Metric/GetDatumParallel-8-4                                                     5.13µs ±13%    5.80µs ±11%     ~     (p=0.095 n=5+5)
Metric/GetDatumParallel-16                                                      10.6µs ± 2%    11.8µs ± 6%  +11.07%  (p=0.008 n=5+5)
Metric/GetDatumParallel-16-2                                                    10.0µs ± 5%    10.7µs ± 7%   +7.07%  (p=0.032 n=5+5)
Metric/GetDatumParallel-16-4                                                    11.3µs ± 8%    12.6µs ± 8%  +11.52%  (p=0.032 n=5+5)
Metric/GetDatumParallel-32                                                      21.9µs ±11%    25.7µs ± 3%  +16.95%  (p=0.008 n=5+5)
Metric/GetDatumParallel-32-2                                                    21.1µs ± 3%    24.0µs ± 5%  +13.76%  (p=0.008 n=5+5)
Metric/GetDatumParallel-32-4                                                    21.8µs ± 2%    26.9µs ± 9%  +23.57%  (p=0.008 n=5+5)
Metric/GetDatumParallel-64                                                      45.5µs ± 1%    53.2µs ± 3%  +16.85%  (p=0.008 n=5+5)
Metric/GetDatumParallel-64-2                                                    41.1µs ± 7%    46.8µs ± 4%  +13.81%  (p=0.008 n=5+5)
Metric/GetDatumParallel-64-4                                                    46.1µs ± 1%    52.4µs ± 5%  +13.56%  (p=0.008 n=5+5)
Metric/GetDatumParallel-128                                                      101µs ± 2%     113µs ± 4%  +12.11%  (p=0.008 n=5+5)
Metric/GetDatumParallel-128-2                                                   90.1µs ± 3%   102.8µs ± 3%  +14.16%  (p=0.008 n=5+5)
Metric/GetDatumParallel-128-4                                                    101µs ± 1%     112µs ± 2%  +11.06%  (p=0.008 n=5+5)
Metric/GetDatumParallel-256                                                      242µs ± 4%     247µs ± 5%     ~     (p=0.690 n=5+5)
Metric/GetDatumParallel-256-2                                                    198µs ± 1%     218µs ± 2%  +10.06%  (p=0.008 n=5+5)
Metric/GetDatumParallel-256-4                                                    215µs ± 3%     238µs ± 2%  +10.95%  (p=0.008 n=5+5)
Metric/GetDatumParallel-512                                                      473µs ± 2%     515µs ± 2%   +8.88%  (p=0.008 n=5+5)
Metric/GetDatumParallel-512-2                                                    438µs ± 6%     451µs ± 1%     ~     (p=0.690 n=5+5)
Metric/GetDatumParallel-512-4                                                    481µs ± 6%     489µs ± 4%     ~     (p=0.841 n=5+5)
Metric/GetDatumParallel-1024                                                     977µs ± 1%    1050µs ± 3%   +7.54%  (p=0.008 n=5+5)
Metric/GetDatumParallel-1024-2                                                   912µs ± 3%     949µs ± 2%   +4.04%  (p=0.008 n=5+5)
Metric/GetDatumParallel-1024-4                                                   970µs ± 3%    1053µs ± 3%   +8.56%  (p=0.008 n=5+5)
Metric/GetDatumParallel-2048                                                    2.05ms ± 2%    2.76ms ± 6%  +34.66%  (p=0.008 n=5+5)
Metric/GetDatumParallel-2048-2                                                  1.75ms ± 2%    2.67ms ± 6%  +52.84%  (p=0.008 n=5+5)
Metric/GetDatumParallel-2048-4                                                  1.97ms ± 6%    2.74ms ± 5%  +39.35%  (p=0.008 n=5+5)
Metric/GetDatumParallel-4096                                                    4.51ms ± 1%    6.96ms ± 3%  +54.49%  (p=0.008 n=5+5)
Metric/GetDatumParallel-4096-2                                                  3.60ms ± 2%    5.98ms ± 2%  +65.97%  (p=0.008 n=5+5)
Metric/GetDatumParallel-4096-4                                                  3.98ms ± 4%    6.26ms ± 6%  +57.17%  (p=0.008 n=5+5)
Metric/GetDatumParallel-8192                                                    10.6ms ± 1%    14.6ms ± 6%  +37.85%  (p=0.016 n=4+5)
Metric/GetDatumParallel-8192-2                                                  8.45ms ± 5%   12.59ms ± 3%  +49.00%  (p=0.008 n=5+5)
Metric/GetDatumParallel-8192-4                                                  8.61ms ± 5%   13.12ms ± 2%  +52.34%  (p=0.008 n=5+5)
pkg:github.com/google/mtail/internal/metrics/datum goos:linux goarch:amd64
IncrementScalarInt                                                              20.9ns ± 0%    21.7ns ± 2%   +3.88%  (p=0.008 n=5+5)
IncrementScalarInt-2                                                            22.0ns ± 5%    21.5ns ± 0%     ~     (p=0.643 n=5+5)
IncrementScalarInt-4                                                            21.2ns ± 4%    22.0ns ± 2%     ~     (p=0.056 n=5+5)
DecrementScalarInt                                                              20.9ns ± 0%    21.8ns ± 2%   +4.55%  (p=0.016 n=4+5)
DecrementScalarInt-2                                                            21.1ns ± 3%    21.5ns ± 1%     ~     (p=0.151 n=5+5)
DecrementScalarInt-4                                                            22.1ns ± 5%    21.6ns ± 3%     ~     (p=0.341 n=5+5)
pkg:github.com/google/mtail/internal/mtail goos:linux goarch:amd64
Program/examples/rsyncd.mtail_on_testdata/rsyncd.log                            4.69ms ± 7%    4.96ms ± 2%     ~     (p=0.421 n=5+5)
Program/examples/rsyncd.mtail_on_testdata/rsyncd.log-2                          4.93ms ± 3%    5.30ms ± 2%   +7.44%  (p=0.008 n=5+5)
Program/examples/rsyncd.mtail_on_testdata/rsyncd.log-4                          4.70ms ± 2%    5.22ms ± 2%  +11.06%  (p=0.008 n=5+5)
Program/examples/sftp.mtail_on_testdata/sftp_chroot.log                         1.74ms ± 7%    1.90ms ± 3%   +9.41%  (p=0.016 n=5+5)
Program/examples/sftp.mtail_on_testdata/sftp_chroot.log-2                       1.82ms ± 1%    2.00ms ± 3%   +9.60%  (p=0.008 n=5+5)
Program/examples/sftp.mtail_on_testdata/sftp_chroot.log-4                       1.77ms ± 1%    1.97ms ± 3%  +11.61%  (p=0.008 n=5+5)
Program/examples/dhcpd.mtail_on_testdata/anonymised_dhcpd_log                    1.22s ± 0%     1.33s ± 0%   +8.94%  (p=0.029 n=4+4)
Program/examples/dhcpd.mtail_on_testdata/anonymised_dhcpd_log-2                  1.34s ± 2%     1.40s ± 1%   +4.70%  (p=0.008 n=5+5)
Program/examples/dhcpd.mtail_on_testdata/anonymised_dhcpd_log-4                  1.28s ± 2%     1.40s ± 4%   +8.71%  (p=0.008 n=5+5)
Program/examples/ntpd.mtail_on_testdata/ntp4                                     291µs ± 1%     332µs ± 1%  +14.08%  (p=0.008 n=5+5)
Program/examples/ntpd.mtail_on_testdata/ntp4-2                                   297µs ± 5%     333µs ± 4%  +12.19%  (p=0.008 n=5+5)
Program/examples/ntpd.mtail_on_testdata/ntp4-4                                   298µs ± 2%     334µs ± 2%  +12.26%  (p=0.008 n=5+5)
Program/examples/ntpd_peerstats.mtail_on_testdata/xntp3_peerstats               90.6µs ±17%    99.9µs ±12%     ~     (p=0.095 n=5+5)
Program/examples/ntpd_peerstats.mtail_on_testdata/xntp3_peerstats-2             68.1µs ± 4%    76.9µs ± 2%  +12.81%  (p=0.008 n=5+5)
Program/examples/ntpd_peerstats.mtail_on_testdata/xntp3_peerstats-4             69.8µs ± 0%    84.7µs ± 2%  +21.36%  (p=0.008 n=5+5)
Program/examples/apache_combined.mtail_on_testdata/apache-combined.log           154µs ± 1%     182µs ± 0%  +18.16%  (p=0.029 n=4+4)
Program/examples/apache_combined.mtail_on_testdata/apache-combined.log-2         134µs ± 4%     167µs ± 6%  +24.66%  (p=0.008 n=5+5)
Program/examples/apache_combined.mtail_on_testdata/apache-combined.log-4         147µs ± 4%     178µs ± 4%  +20.78%  (p=0.008 n=5+5)
Program/examples/apache_common.mtail_on_testdata/apache-common.log               136µs ± 1%     162µs ± 1%  +19.25%  (p=0.008 n=5+5)
Program/examples/apache_common.mtail_on_testdata/apache-common.log-2             131µs ± 4%     159µs ± 1%  +21.30%  (p=0.016 n=5+4)
Program/examples/apache_common.mtail_on_testdata/apache-common.log-4             130µs ±10%     160µs ± 4%  +23.24%  (p=0.008 n=5+5)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_log                             843µs ± 1%     930µs ± 2%  +10.27%  (p=0.008 n=5+5)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_log-2                           872µs ± 3%     949µs ± 1%   +8.89%  (p=0.008 n=5+5)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_log-4                           879µs ± 3%     939µs ± 2%   +6.79%  (p=0.008 n=5+5)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_xferlog                         148µs ±27%     157µs ± 1%     ~     (p=0.190 n=5+4)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_xferlog-2                       125µs ± 2%     155µs ± 7%  +24.05%  (p=0.008 n=5+5)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_xferlog-4                       133µs ± 6%     147µs ± 2%  +10.43%  (p=0.008 n=5+5)
Program/examples/lighttpd.mtail_on_testdata/lighttpd_access.log                  151µs ± 1%     177µs ± 1%  +17.49%  (p=0.008 n=5+5)
Program/examples/lighttpd.mtail_on_testdata/lighttpd_access.log-2                143µs ± 2%     172µs ± 2%  +20.36%  (p=0.016 n=5+4)
Program/examples/lighttpd.mtail_on_testdata/lighttpd_access.log-4                144µs ± 3%     168µs ± 2%  +16.20%  (p=0.016 n=4+5)
Program/examples/mysql_slowqueries.mtail_on_testdata/mysql_slowqueries.log       585µs ± 0%     649µs ± 2%  +10.88%  (p=0.008 n=5+5)
Program/examples/mysql_slowqueries.mtail_on_testdata/mysql_slowqueries.log-2     599µs ± 2%     655µs ± 0%   +9.42%  (p=0.008 n=5+5)
Program/examples/mysql_slowqueries.mtail_on_testdata/mysql_slowqueries.log-4     596µs ± 3%     667µs ± 3%  +11.90%  (p=0.008 n=5+5)

name                                                                          old speed      new speed      delta
pkg:github.com/google/mtail/internal/mtail goos:linux goarch:amd64
Program/examples/rsyncd.mtail_on_testdata/rsyncd.log                          1.01GB/s ±14%  0.89GB/s ± 4%     ~     (p=0.222 n=5+5)
Program/examples/rsyncd.mtail_on_testdata/rsyncd.log-2                         911MB/s ± 5%   785MB/s ± 6%  -13.84%  (p=0.008 n=5+5)
Program/examples/rsyncd.mtail_on_testdata/rsyncd.log-4                         984MB/s ± 5%   808MB/s ± 3%  -17.86%  (p=0.008 n=5+5)
Program/examples/sftp.mtail_on_testdata/sftp_chroot.log                       8.27GB/s ± 1%  6.70GB/s ± 7%  -19.03%  (p=0.016 n=4+5)
Program/examples/sftp.mtail_on_testdata/sftp_chroot.log-2                     7.24GB/s ± 4%  6.18GB/s ± 6%  -14.65%  (p=0.008 n=5+5)
Program/examples/sftp.mtail_on_testdata/sftp_chroot.log-4                     7.72GB/s ± 3%  6.09GB/s ± 3%  -21.05%  (p=0.008 n=5+5)
Program/examples/dhcpd.mtail_on_testdata/anonymised_dhcpd_log                 4.46MB/s ± 0%  4.09MB/s ± 0%   -8.14%  (p=0.029 n=4+4)
Program/examples/dhcpd.mtail_on_testdata/anonymised_dhcpd_log-2               4.07MB/s ± 2%  3.88MB/s ± 1%   -4.52%  (p=0.008 n=5+5)
Program/examples/dhcpd.mtail_on_testdata/anonymised_dhcpd_log-4               4.23MB/s ± 2%  3.89MB/s ± 4%   -7.94%  (p=0.008 n=5+5)
Program/examples/ntpd.mtail_on_testdata/ntp4                                  14.9GB/s ± 1%  11.3GB/s ±10%  -24.27%  (p=0.008 n=5+5)
Program/examples/ntpd.mtail_on_testdata/ntp4-2                                13.9GB/s ± 8%  11.1GB/s ± 4%  -19.75%  (p=0.008 n=5+5)
Program/examples/ntpd.mtail_on_testdata/ntp4-4                                13.7GB/s ±10%  11.0GB/s ±10%  -19.47%  (p=0.008 n=5+5)
Program/examples/ntpd_peerstats.mtail_on_testdata/xntp3_peerstats             8.91GB/s ±12%  6.96GB/s ±27%  -21.85%  (p=0.008 n=5+5)
Program/examples/ntpd_peerstats.mtail_on_testdata/xntp3_peerstats-2           14.7GB/s ± 9%  11.6GB/s ± 4%  -20.84%  (p=0.008 n=5+5)
Program/examples/ntpd_peerstats.mtail_on_testdata/xntp3_peerstats-4           13.8GB/s ± 3%   9.5GB/s ± 2%  -30.80%  (p=0.008 n=5+5)
Program/examples/apache_combined.mtail_on_testdata/apache-combined.log        31.2GB/s ±42%  21.7GB/s ±30%     ~     (p=0.095 n=5+5)
Program/examples/apache_combined.mtail_on_testdata/apache-combined.log-2      42.5GB/s ±11%  29.8GB/s ±10%  -29.78%  (p=0.008 n=5+5)
Program/examples/apache_combined.mtail_on_testdata/apache-combined.log-4      36.3GB/s ± 4%  25.3GB/s ±13%  -30.33%  (p=0.008 n=5+5)
Program/examples/apache_common.mtail_on_testdata/apache-common.log            20.5GB/s ± 8%  14.4GB/s ± 8%  -29.39%  (p=0.008 n=5+5)
Program/examples/apache_common.mtail_on_testdata/apache-common.log-2          21.1GB/s ± 7%  12.8GB/s ±38%  -39.57%  (p=0.008 n=5+5)
Program/examples/apache_common.mtail_on_testdata/apache-common.log-4          22.4GB/s ±10%  14.8GB/s ±13%  -33.97%  (p=0.008 n=5+5)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_log                          20.5GB/s ± 2%  16.6GB/s ± 3%  -19.27%  (p=0.008 n=5+5)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_log-2                        19.2GB/s ± 5%  16.6GB/s ± 5%  -13.73%  (p=0.008 n=5+5)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_log-4                        18.4GB/s ± 8%  16.2GB/s ± 5%  -11.95%  (p=0.008 n=5+5)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_xferlog                      68.7GB/s ±25%  52.6GB/s ± 9%     ~     (p=0.095 n=5+5)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_xferlog-2                    85.5GB/s ± 7%  60.0GB/s ±11%  -29.85%  (p=0.008 n=5+5)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_xferlog-4                    78.6GB/s ±18%  67.3GB/s ± 8%     ~     (p=0.151 n=5+5)
Program/examples/lighttpd.mtail_on_testdata/lighttpd_access.log                139GB/s ± 5%    98GB/s ± 6%  -29.54%  (p=0.008 n=5+5)
Program/examples/lighttpd.mtail_on_testdata/lighttpd_access.log-2              150GB/s ±10%    96GB/s ±20%  -35.82%  (p=0.008 n=5+5)
Program/examples/lighttpd.mtail_on_testdata/lighttpd_access.log-4              141GB/s ±21%   114GB/s ± 8%     ~     (p=0.056 n=5+5)
Program/examples/mysql_slowqueries.mtail_on_testdata/mysql_slowqueries.log    4.84GB/s ± 3%  3.92GB/s ± 5%  -19.10%  (p=0.008 n=5+5)
Program/examples/mysql_slowqueries.mtail_on_testdata/mysql_slowqueries.log-2  4.49GB/s ± 8%  3.80GB/s ± 3%  -15.26%  (p=0.008 n=5+5)
Program/examples/mysql_slowqueries.mtail_on_testdata/mysql_slowqueries.log-4  4.48GB/s ± 9%  3.68GB/s ± 7%  -17.78%  (p=0.008 n=5+5)

name                                                                          old alloc/op   new alloc/op   delta
pkg:github.com/google/mtail/internal/mtail goos:linux goarch:amd64
Program/examples/rsyncd.mtail_on_testdata/rsyncd.log                             268kB ± 0%     268kB ± 0%     ~     (p=0.365 n=5+5)
Program/examples/rsyncd.mtail_on_testdata/rsyncd.log-2                           270kB ± 0%     270kB ± 0%     ~     (p=0.738 n=5+5)
Program/examples/rsyncd.mtail_on_testdata/rsyncd.log-4                           272kB ± 0%     272kB ± 1%     ~     (p=0.841 n=5+5)
Program/examples/sftp.mtail_on_testdata/sftp_chroot.log                          209kB ± 0%     209kB ± 0%     ~     (p=0.476 n=5+5)
Program/examples/sftp.mtail_on_testdata/sftp_chroot.log-2                        209kB ± 0%     209kB ± 0%     ~     (p=0.286 n=5+5)
Program/examples/sftp.mtail_on_testdata/sftp_chroot.log-4                        210kB ± 0%     210kB ± 0%     ~     (p=1.000 n=5+5)
Program/examples/dhcpd.mtail_on_testdata/anonymised_dhcpd_log                    100MB ± 0%     100MB ± 0%     ~     (p=0.686 n=4+4)
Program/examples/dhcpd.mtail_on_testdata/anonymised_dhcpd_log-2                  100MB ± 0%     100MB ± 0%     ~     (p=0.421 n=5+5)
Program/examples/dhcpd.mtail_on_testdata/anonymised_dhcpd_log-4                  101MB ± 0%     101MB ± 0%     ~     (p=0.548 n=5+5)
Program/examples/ntpd.mtail_on_testdata/ntp4                                    52.3kB ± 0%    52.3kB ± 0%     ~     (p=0.905 n=5+5)
Program/examples/ntpd.mtail_on_testdata/ntp4-2                                  52.4kB ± 0%    52.4kB ± 0%     ~     (p=1.000 n=5+5)
Program/examples/ntpd.mtail_on_testdata/ntp4-4                                  52.8kB ± 0%    52.9kB ± 0%     ~     (p=0.548 n=5+5)
Program/examples/ntpd_peerstats.mtail_on_testdata/xntp3_peerstats               36.4kB ± 0%    36.4kB ± 0%     ~     (all equal)
Program/examples/ntpd_peerstats.mtail_on_testdata/xntp3_peerstats-2             36.4kB ± 0%    36.4kB ± 0%   -0.04%  (p=0.040 n=5+5)
Program/examples/ntpd_peerstats.mtail_on_testdata/xntp3_peerstats-4             36.7kB ± 0%    36.7kB ± 0%     ~     (p=0.841 n=5+5)
Program/examples/apache_combined.mtail_on_testdata/apache-combined.log          46.5kB ± 0%    46.5kB ± 0%     ~     (p=0.444 n=5+5)
Program/examples/apache_combined.mtail_on_testdata/apache-combined.log-2        46.6kB ± 0%    46.6kB ± 0%     ~     (p=1.000 n=5+5)
Program/examples/apache_combined.mtail_on_testdata/apache-combined.log-4        47.0kB ± 0%    46.9kB ± 0%     ~     (p=0.548 n=5+5)
Program/examples/apache_common.mtail_on_testdata/apache-common.log              44.8kB ± 0%    44.8kB ± 0%   +0.00%  (p=0.016 n=4+5)
Program/examples/apache_common.mtail_on_testdata/apache-common.log-2            44.8kB ± 0%    44.9kB ± 0%     ~     (p=0.167 n=5+5)
Program/examples/apache_common.mtail_on_testdata/apache-common.log-4            45.3kB ± 0%    45.3kB ± 0%     ~     (p=0.548 n=5+5)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_log                             125kB ± 0%     125kB ± 0%   +0.00%  (p=0.016 n=4+5)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_log-2                           126kB ± 0%     126kB ± 0%     ~     (p=0.310 n=5+5)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_log-4                           126kB ± 0%     126kB ± 0%     ~     (p=0.310 n=5+5)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_xferlog                        42.2kB ± 0%    42.2kB ± 0%     ~     (p=0.444 n=5+5)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_xferlog-2                      42.3kB ± 0%    42.3kB ± 0%     ~     (p=0.889 n=5+5)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_xferlog-4                      42.5kB ± 0%    42.5kB ± 0%     ~     (p=0.643 n=5+5)
Program/examples/lighttpd.mtail_on_testdata/lighttpd_access.log                 47.2kB ± 0%    47.2kB ± 0%   +0.00%  (p=0.008 n=5+5)
Program/examples/lighttpd.mtail_on_testdata/lighttpd_access.log-2               47.2kB ± 0%    47.2kB ± 0%     ~     (p=0.056 n=5+5)
Program/examples/lighttpd.mtail_on_testdata/lighttpd_access.log-4               47.5kB ± 0%    47.4kB ± 0%     ~     (p=0.103 n=5+5)
Program/examples/mysql_slowqueries.mtail_on_testdata/mysql_slowqueries.log      79.4kB ± 0%    79.4kB ± 0%   +0.00%  (p=0.032 n=4+5)
Program/examples/mysql_slowqueries.mtail_on_testdata/mysql_slowqueries.log-2    79.5kB ± 0%    79.5kB ± 0%     ~     (p=0.690 n=5+5)
Program/examples/mysql_slowqueries.mtail_on_testdata/mysql_slowqueries.log-4    80.0kB ± 0%    79.9kB ± 0%     ~     (p=0.222 n=5+5)

name                                                                          old allocs/op  new allocs/op  delta
pkg:github.com/google/mtail/internal/mtail goos:linux goarch:amd64
Program/examples/rsyncd.mtail_on_testdata/rsyncd.log                             5.45k ± 0%     5.45k ± 0%     ~     (all equal)
Program/examples/rsyncd.mtail_on_testdata/rsyncd.log-2                           5.45k ± 0%     5.45k ± 0%     ~     (all equal)
Program/examples/rsyncd.mtail_on_testdata/rsyncd.log-4                           5.45k ± 0%     5.45k ± 0%     ~     (all equal)
Program/examples/sftp.mtail_on_testdata/sftp_chroot.log                          3.06k ± 0%     3.05k ± 0%     ~     (p=0.444 n=5+5)
Program/examples/sftp.mtail_on_testdata/sftp_chroot.log-2                        3.06k ± 0%     3.05k ± 0%     ~     (p=0.167 n=5+5)
Program/examples/sftp.mtail_on_testdata/sftp_chroot.log-4                        3.06k ± 0%     3.06k ± 0%     ~     (all equal)
Program/examples/dhcpd.mtail_on_testdata/anonymised_dhcpd_log                    1.10M ± 0%     1.10M ± 0%     ~     (p=0.421 n=5+5)
Program/examples/dhcpd.mtail_on_testdata/anonymised_dhcpd_log-2                  1.10M ± 0%     1.10M ± 0%     ~     (p=0.841 n=5+5)
Program/examples/dhcpd.mtail_on_testdata/anonymised_dhcpd_log-4                  1.10M ± 0%     1.10M ± 0%     ~     (p=0.690 n=5+5)
Program/examples/ntpd.mtail_on_testdata/ntp4                                       223 ± 0%       223 ± 0%     ~     (all equal)
Program/examples/ntpd.mtail_on_testdata/ntp4-2                                     223 ± 0%       223 ± 0%     ~     (all equal)
Program/examples/ntpd.mtail_on_testdata/ntp4-4                                     223 ± 0%       223 ± 0%     ~     (all equal)
Program/examples/ntpd_peerstats.mtail_on_testdata/xntp3_peerstats                 82.0 ± 0%      82.0 ± 0%     ~     (all equal)
Program/examples/ntpd_peerstats.mtail_on_testdata/xntp3_peerstats-2               82.0 ± 0%      82.0 ± 0%     ~     (all equal)
Program/examples/ntpd_peerstats.mtail_on_testdata/xntp3_peerstats-4               82.0 ± 0%      82.0 ± 0%     ~     (all equal)
Program/examples/apache_combined.mtail_on_testdata/apache-combined.log             223 ± 0%       223 ± 0%     ~     (all equal)
Program/examples/apache_combined.mtail_on_testdata/apache-combined.log-2           223 ± 0%       222 ± 0%     ~     (p=0.095 n=4+5)
Program/examples/apache_combined.mtail_on_testdata/apache-combined.log-4           223 ± 0%       223 ± 0%     ~     (all equal)
Program/examples/apache_common.mtail_on_testdata/apache-common.log                 209 ± 0%       209 ± 0%     ~     (all equal)
Program/examples/apache_common.mtail_on_testdata/apache-common.log-2               210 ± 0%       209 ± 0%   -0.48%  (p=0.008 n=5+5)
Program/examples/apache_common.mtail_on_testdata/apache-common.log-4               210 ± 0%       210 ± 0%     ~     (all equal)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_log                             1.65k ± 0%     1.65k ± 0%     ~     (all equal)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_log-2                           1.65k ± 0%     1.65k ± 0%     ~     (all equal)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_log-4                           1.65k ± 0%     1.65k ± 0%     ~     (all equal)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_xferlog                           155 ± 0%       155 ± 0%     ~     (all equal)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_xferlog-2                         155 ± 0%       155 ± 0%     ~     (all equal)
Program/examples/vsftpd.mtail_on_testdata/vsftpd_xferlog-4                         155 ± 0%       155 ± 0%     ~     (all equal)
Program/examples/lighttpd.mtail_on_testdata/lighttpd_access.log                    177 ± 0%       177 ± 0%     ~     (all equal)
Program/examples/lighttpd.mtail_on_testdata/lighttpd_access.log-2                  177 ± 0%       177 ± 0%     ~     (all equal)
Program/examples/lighttpd.mtail_on_testdata/lighttpd_access.log-4                  177 ± 0%       177 ± 0%     ~     (all equal)
Program/examples/mysql_slowqueries.mtail_on_testdata/mysql_slowqueries.log         891 ± 0%       891 ± 0%     ~     (all equal)
Program/examples/mysql_slowqueries.mtail_on_testdata/mysql_slowqueries.log-2       891 ± 0%       891 ± 0%     ~     (all equal)
Program/examples/mysql_slowqueries.mtail_on_testdata/mysql_slowqueries.log-4       892 ± 0%       892 ± 0%     ~     (all equal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NFS: Stale file handle - after log cycling occurs.
1 participant
@jaqx0r