-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help testing magika 0.6.0rcX
and collect problems
#798
Comments
Issue: on Mac, Opened an issue with the uv folks: astral-sh/uv#9228 Fix is to add a version constraint for onnxruntime. Tracking here: #801. |
0.6.0rc2
and collect problems0.6.0rcX
and collect problems
It looks like magika 0.6 is no longer pure Python. The RC on PyPI is missing builds for platforms like linux aarch64 |
Thanks for reporting; that's something we would like to fix. We'll look into this. In the meantime, if you have any pointer on how to extend the compilation to these other platforms with github runners, please let us know, thanks! /cc @ia0 |
You can try to modify #851, in particular the rust/onnx/build.sh and maturin.sh files. I got onnx to build but it fails the test suite: https://github.com/google/magika/actions/runs/12716267732/job/35450215968?pr=851 |
You can use qemu to emulate aarch64 on Github's x86 runners, see e.g. https://github.com/openai/tiktoken/blob/main/.github/workflows/build_wheels.yml#L47 |
The problem is not the theory but the practice. ONNX Runtime indeed recommends emulation (easy and slow) rather than cross-compilation (difficult and fast). The thing is we use So there's 3 options:
If you want to try any of those options, that would be great! Otherwise, I'll try to look at it eventually (my preference is the third option, but if it's really too much work, I'll try the second). It would be indeed nice to support Linux aarch64. |
I don't know if it's a regression of #371, but event trace logs files aren't being detected correctly for me. |
Not really a regression; Supporting that file format didn't make it yet in any model we have (Context: There are many GH issues like those; we closed them and tagged them with a special label so that we know what to work on next, but "closed github issue" != "supported".) |
Update on "the wheels are not pure python anymore": the way we are going to address this is that, in addition to the three binary wheels for popular platforms (that ship the rust client), we are going to build a pure-python wheel as well, which will ship the old python client instead of the new rust one (with the new model). With time, we'll try to create and publish binary wheels for more platforms, but this seems to be a good tradeoffs, so that no existing clients is left behind. WIP PR #909, more context in #870. Feedback is welcome! |
We have uploaded
magika 0.6.0rc2
to pypi: https://pypi.org/project/magika/0.6.0rc2/ (and we'll keep pushing minor updates as new -rcX).This version, which will become
0.6.0
introduces many more content types and some changes (some of which breaking, but should be easy to port to new version). This version also ships the rust CLI, together with the python API.Please help us testing this new version on various platforms. To install the latest -rc:
pip install --pre magika
.To ease tracking, please report any problem by creating a new github issue and reference this #798 issue.
The text was updated successfully, but these errors were encountered: