Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code health] Refactor map based view models for data collection tasks #2978

Closed
shobhitagarwal1612 opened this issue Jan 4, 2025 · 0 comments · Fixed by #2979
Closed

[Code health] Refactor map based view models for data collection tasks #2978

shobhitagarwal1612 opened this issue Jan 4, 2025 · 0 comments · Fixed by #2979
Assignees
@shobhitagarwal1612
Labels
type: code health Improvements to readability or robustness of codebase

Comments

@shobhitagarwal1612
Copy link
Member

shobhitagarwal1612 commented Jan 4, 2025 •
edited
Loading

Some ideas:

  • CaptureLocationTaskMapViewModel only contains mapConfig which is used by fragments only. So, if we move the mapConfig to AbstractMapContainerFragment then we can use default BaseMapViewModel in CaptureLocationTaskMapFragment
  • Creation logic for parent and child view models in task based map fragments is common and can be pulled into abstract class
  • Rending map features
@shobhitagarwal1612 shobhitagarwal1612 added the type: code health Improvements to readability or robustness of codebase label Jan 4, 2025
@shobhitagarwal1612 shobhitagarwal1612 self-assigned this Jan 4, 2025
@shobhitagarwal1612 shobhitagarwal1612 mentioned this issue Jan 4, 2025
Merged
@shobhitagarwal1612 shobhitagarwal1612 moved this to In Progress in Ground Jan 4, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Ground Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shobhitagarwal1612 shobhitagarwal1612

Labels
type: code health Improvements to readability or robustness of codebase
Projects
Ground
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup map based task fragments google/ground-android
1 participant
@shobhitagarwal1612