Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grain should not have jax dependency #668

Open
SamuelMarks opened this issue Dec 21, 2024 · 1 comment
Open

grain should not have jax dependency #668

SamuelMarks opened this issue Dec 21, 2024 · 1 comment

Comments

@SamuelMarks
Copy link
Contributor

@ 77c56dc with Python (CPython) 3.10.16, setuptools 75.6.0, wheel 0.45.1 on x86_64 Linux:

$ python -m pip install .
$ python -c 'import grain.python as grain'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "grain/grain/python.py", line 21, in <module>
    from . import python_experimental as experimental
  File "grain/grain/python_experimental.py", line 48, in <module>
    from ._src.python.dataset.transformations.packing import FirstFitPackIterDataset
  File "grain/grain/_src/python/dataset/transformations/packing.py", line 21, in <module>
    from grain._src.python.dataset.transformations import packing_packed_batch
  File "grain/grain/_src/python/dataset/transformations/packing_packed_batch.py", line 23, in <module>
    import jax
ModuleNotFoundError: No module named 'jax'

But at that same commit your README reads:
https://github.com/google/grain/blob/77c56dc/README.md?#L30

Grain is designed to work with JAX models but it does not require JAX to run and can be used with other frameworks as well.

@iindyk
Copy link
Collaborator

iindyk commented Jan 2, 2025

thanks for flagging this, let me prepare a pr with a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants