Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up code style in generators for field colour blocks #2198

Closed
1 task done
rachel-fenichel opened this issue Feb 9, 2024 · 0 comments
Closed
1 task done

Clean up code style in generators for field colour blocks #2198

rachel-fenichel opened this issue Feb 9, 2024 · 0 comments
Labels
type: feature request New feature or request

Comments

@rachel-fenichel
Copy link
Collaborator

Check for duplicates

  • I have searched for similar issues before opening a new one.

Component

No response

Problem

No response

Request

Follow-up work from #2162.

Clean up the generator code (which is returned as a string) for blocks in field-colour.

For example, Christopher suggested this change in the Python code for the blend block:

-    functionName + '(' + colour1 + ', ' + colour2 + ', ' + ratio + ')';
+  const code = `${functionName}(${colour1}, ${colour2}, ${ratio})`;

Alternatives considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant