Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth Streaming {CustomAttributes} placeholder not supported #2478

Open
alfonsoramosa opened this issue Feb 20, 2017 · 1 comment
Open

Smooth Streaming {CustomAttributes} placeholder not supported #2478

alfonsoramosa opened this issue Feb 20, 2017 · 1 comment

Comments

@alfonsoramosa
Copy link

Exoplayer 2.2.0
Device: Nexus player
Android 7.1.1

Exoplayer is not working with some Smooth Streaming manifests.
That's happening when the Url for a StreamIndex has a CustomAttributes placeholder.
This placeholder is not replaced with a value.

Manifest example:

<StreamIndex Type="audio" QualityLevels="3" TimeScale="10000000" Language="multiple" Name="audio_0" Chunks="21" Url="QualityLevels({bitrate},{CustomAttributes})/Fragments(audio_0={start_time})">
  <QualityLevel Index="0" Bitrate="48000" CodecPrivateData="1190" SamplingRate="48000" Channels="2" BitsPerSample="0" PacketSize="4" AudioTag="255" FourCC="AACL">
    <CustomAttributes>
      <Attribute Name="Language" Value="eng"/>
    </CustomAttributes>
  </QualityLevel>
  <QualityLevel Index="1" Bitrate="128000" CodecPrivateData="1190" SamplingRate="48000" Channels="2" BitsPerSample="0" PacketSize="4" AudioTag="255" FourCC="AACL">
    <CustomAttributes>
      <Attribute Name="Language" Value="eng"/>
    </CustomAttributes>
  </QualityLevel>
  <QualityLevel Index="2" Bitrate="192000" CodecPrivateData="1190" SamplingRate="48000" Channels="2" BitsPerSample="0" PacketSize="4" AudioTag="255" FourCC="AACL">
    <CustomAttributes>
      <Attribute Name="Language" Value="eng"/>
    </CustomAttributes>
  </QualityLevel> 
...
</StreamIndex>
@ojw28
Copy link
Contributor

ojw28 commented Feb 20, 2017

Please feel free to send a pull request to dev-v2 to fix this.

@ojw28 ojw28 assigned tonihei and unassigned ojw28 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants