Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Multiple Node Styler dialogs appear on repeated palette button clicks #287

Open
tonyz0x0 opened this issue Feb 1, 2025 · 2 comments
Assignees
Labels
front-end For issues where the root is mostly occurring on the front-end type:bug Bug

Comments

@tonyz0x0
Copy link

tonyz0x0 commented Feb 1, 2025

Description

I've identified a UI bug in the model visualizer's node styling functionality. When users click the "Style nodes with custom rules" palette button multiple times, the application creates multiple dialog instances instead of maintaining a single dialog.

Current Behavior

When clicking the palette button multiple times:

  • Each click creates a new Node Styler dialog
  • Multiple dialogs stack on top of each other
  • No check is performed to prevent duplicate dialogs
  • This creates a confusing user experience and potentially impacts performance

Expected Behavior

  • Only one Node Styler dialog should be visible at any time
  • Subsequent clicks on the palette button while a dialog is open should not create new dialogs
  • The dialog should maintain its state between clicks

Steps to Reproduce

  1. Open the model visualizer
  2. Locate the palette button (Style nodes with custom rules) in the top right corner
  3. Click the button multiple times in succession
  4. Observe multiple identical dialogs appearing
Image
@pkgoogle
Copy link
Contributor

pkgoogle commented Feb 3, 2025

Hi @tonyz0x0, I'm not 100% sure this is a bug, it may be expected behavior. @jinjingforever can you please take a look? Thanks.

@pkgoogle pkgoogle added type:bug Bug front-end For issues where the root is mostly occurring on the front-end labels Feb 3, 2025
@jinjingforever
Copy link
Collaborator

This is indeed a bug. Thanks for the report @tonyz0x0! I will fix it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end For issues where the root is mostly occurring on the front-end type:bug Bug
Projects
None yet
Development

No branches or pull requests

3 participants