Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongooseFactory errors do not cause an exception #16

Open
mb-dev opened this issue Jul 29, 2015 · 2 comments
Open

mongooseFactory errors do not cause an exception #16

mb-dev opened this issue Jul 29, 2015 · 2 comments

Comments

@mb-dev
Copy link

mb-dev commented Jul 29, 2015

Steps to reproduce:
Create a mongoose factory for a model that has validation. Using the factory create an instance with values that fail the validation.

Expected outcome:
Failure is returned on the callback

Actual:
Callback returns okay with undefined value

@hazeledmands
Copy link
Contributor

Hey @mb-dev, unfortunately, I just created a passing test that cannot reproduce this bug. See 0e4f5af

I think something else might be going on in your code.

@mb-dev
Copy link
Author

mb-dev commented Jul 29, 2015

The failed tests are when using mongoose 3.6.

I cloned unionized, installed 3.6 and ran tests:

screen shot 2015-07-29 at 9 53 48 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants