Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golem-cli plugin list Fails with Parsing Error #1299

Open
Nanashi-lab opened this issue Feb 8, 2025 · 1 comment
Open

golem-cli plugin list Fails with Parsing Error #1299

Nanashi-lab opened this issue Feb 8, 2025 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@Nanashi-lab
Copy link

Nanashi-lab commented Feb 8, 2025

Description:

The golem-cli plugin list command fails with an error message Unexpected client error: error decoding response body (Likely a Serde JSON Error). This happens despite the /v1/plugins endpoint returning valid JSON when accessed directly.

Steps to Reproduce:

  1. Ensure a Golem backend server is running (e.g., on localhost:9881).
  2. Register a plugin
  3. Run the command golem-cli plugin list

Environment:

  • golem-cli version: 1.1.16

Additional Information:

  • I looked at golem-cli code, but couldn't find the place where plugins data is parsed (I did find where worker, component and api data is parsed). "Unexpected client error: error decoding response body" suggests an issue with how the golem-cli is deserializing the JSON response from the /v1/plugins endpoint. Serde JSON error would contain the specific serde_json error message (e.g., "invalid type: string, expected a sequence", etc.).

  • This error only happens if there is a plugin. The command golem-cli plugin list works fine when there are no plugins

+-------------+----------------+-------------+----------+------+-------+
| Plugin name | Plugin version | Description | Homepage | Type | Scope |
+-------------+----------------+-------------+----------+------+-------+
@vigoo vigoo added the bug Something isn't working label Feb 8, 2025
@vigoo vigoo added this to the Golem 1.2 milestone Feb 8, 2025
@Nanashi-lab
Copy link
Author

This likely happens because json output for each plugin consists of

    "owner": {}

while the parser expects

    "owner": {
      "accountId": "string"
    }

There are a few workaround, but I couldn't a neat way to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants