Potential Keyvalues Memory Leak

[Spirrwell]

Hi.

In c_baseanimating.cpp, there's a function called DelayedInitModelEffects() that's defined at line 1263. This is base class code and I'm not sure what your handling is for that kind of code, though it looks like you use #ifdef GE_DLL. This is nothing huge, but there's a potential KeyValues leak in that function if it ends up returning early in a couple places such as around line 1300.

It's not a particularly big function so it should be easy to figure out. Should do modelKeyValues->deleteThis(); when it returns early.

Found this one day, so figured I'd pass it on. I'm actually interested in helping more, but I haven't played the game before to know what might be broken. Will someday though. Really love the use of CMake. I hate VPC.

[droidmonkey]

Please link to the line in the code.