Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user event and config event #21455

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add user event and config event #21455

wants to merge 1 commit into from

Conversation

stonezdj
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner January 23, 2025 08:40
@stonezdj stonezdj marked this pull request as draft January 23, 2025 08:41
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.25%. Comparing base (c8c11b4) to head (a23cee6).
Report is 378 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21455      +/-   ##
==========================================
+ Coverage   45.36%   46.25%   +0.88%     
==========================================
  Files         244      247       +3     
  Lines       13333    13883     +550     
  Branches     2719     2875     +156     
==========================================
+ Hits         6049     6422     +373     
- Misses       6983     7122     +139     
- Partials      301      339      +38
Flag Coverage Δ
unittests 46.25% <ø> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 25jan15_add_user_event branch from 4551baf to 031defe Compare January 24, 2025 08:45
@stonezdj stonezdj force-pushed the 25jan15_add_user_event branch from 031defe to 400fa1f Compare February 7, 2025 09:19
@stonezdj stonezdj added the release-note/new-feature New Harbor Feature label Feb 7, 2025
@stonezdj stonezdj force-pushed the 25jan15_add_user_event branch from 400fa1f to 0b1fe4b Compare February 7, 2025 09:21
@stonezdj stonezdj marked this pull request as ready for review February 7, 2025 09:21
@stonezdj stonezdj force-pushed the 25jan15_add_user_event branch 2 times, most recently from 58c3ebc to 7c4cd7c Compare February 7, 2025 09:33
@stonezdj stonezdj force-pushed the 25jan15_add_user_event branch from 099ccbf to a23cee6 Compare February 8, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Vad1mo Vad1mo

@wy65701436 wy65701436

@chlins chlins

@MinerYang MinerYang

Labels
release-note/new-feature New Harbor Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stonezdj @Vad1mo @wy65701436 @chlins @MinerYang